[EVM] Support non-precise memory locations in VM AliasAnalysis #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 30.91% 30.92%
=======================================
Files 2430 2430
Lines 806272 806284 +12
Branches 176487 176492 +5
=======================================
+ Hits 249280 249364 +84
+ Misses 513104 513008 -96
- Partials 43888 43912 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📊 Excel Report Available Benchmarks measured for:
|
PavelKopyl
force-pushed
the
kpv-aa-support-non-precise-memloc
branch
4 times, most recently
from
a8a2610 to
c00e1e6
Compare
PavelKopyl
force-pushed
the
kpv-aa-support-non-precise-memloc
branch
from
c00e1e6 to
6ede725
Compare
|
📊 evm compiler-tester excel report Benchmarks measured for:
|
|
|
akiramenai
requested changes
Oct 2, 2025
|
|
||
| // If one of the locations is imprecise, they don’t alias as long as | ||
| // the other location is precise and ends before the first one begins. | ||
| if (LocB.Size == LocationSize::afterPointer()) { |
There was a problem hiding this comment.
Maintainability: I suggest to refactor that code (including DoesOverlap lambda). We have code duplication right below this if, and returning NoAlias, PartialAlias based on a predicate is also become a duplicate.
akiramenai
reviewed
Oct 2, 2025
| call void @llvm.evm.extcodecopy(i256 0, ptr addrspace(1) null, ptr addrspace(4) null, i256 32) | ||
| ret void | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Review Checklist
Purpose
Ticket Number
Requirements
Implementation
Logic Errors and Bugs
code does not behave as intended?
that could break the code?
Error Handling and Logging
be added or removed?
written in a way that allows for easy
debugging?
Maintainability
Dependencies
Security
Performance
system performance?
performance of the code significantly?
Testing and Testability
that should be tested in addition?
Readability
smaller methods?
different function, method or variable names?
file/folder/package?
restructured to have a more intuitive control
flow?
better?
understandable?
Documentation
Best Practices
Experts' Opinion
expert or a usability expert, should look over
the code before it can be accepted?