-
Notifications
You must be signed in to change notification settings - Fork 24
[CGP] Fix missing sign extension for base offset in optimizeMemoryInst #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vladimirradosavljevic
wants to merge
1
commit into
main
Choose a base branch
from
cgp_fix_missing_signextend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akiramenai
reviewed
Sep 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
=======================================
Coverage 30.91% 30.91%
=======================================
Files 2430 2430
Lines 806276 806276
Branches 176487 176487
=======================================
+ Hits 249277 249295 +18
+ Misses 513109 513084 -25
- Partials 43890 43897 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Excel Report Available Benchmarks measured for:
|
If we have integers larger than 64-bit we need to explicitly sign extend them, otherwise we will get wrong zero extended values. Signed-off-by: Vladimir Radosavljevic <[email protected]>
f47b3e9
to
0bfbd3e
Compare
📊 evm compiler-tester excel report Benchmarks measured for:
|
📊 eravm compiler-tester excel report Benchmarks measured for:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.