Skip to content

[MM-68968] Guard redirects and subframe navigations alongside will-navigate (#3927) - #3929

Merged
devinbinnie merged 1 commit into
release-6.2from
MM-68968_cherrypick_release-6.2
Jul 31, 2026
Merged

[MM-68968] Guard redirects and subframe navigations alongside will-navigate (#3927)#3929
devinbinnie merged 1 commit into
release-6.2from
MM-68968_cherrypick_release-6.2

Conversation

@devinbinnie

@devinbinnie devinbinnie commented Jul 31, 2026

Copy link
Copy Markdown
Member

Cherry-pick of #3927 to release-6.2

NONE

Change Impact: 🟡 Medium

Regression Risk: Navigation behavior changes across multiple web contents and popup modules. Automated tests cover main-frame and subframe redirects, which limits regression risk.

QA Recommendation: Skip manual QA. Automated coverage is sufficient for this isolated navigation change.

Generated by CodeRabbitAI

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 731b0dbf-efe8-488b-b3f4-622cd5fad2da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)

Comment @coderabbitai help to get the list of available commands.

@devinbinnie
devinbinnie enabled auto-merge (squash) July 31, 2026 14:44

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/app/views/pluginsPopUps.ts`:
- Line 65: Replace the will-frame-navigate handler registration in the plugin
popup setup with popup-specific logic that resolves the originating server for
parentId, allows subframe URLs only when their origin matches that server, and
blocks while logging all other URLs. Update the corresponding plugin popup test
to assert that an HTTPS URL from a different origin is rejected.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2a003a32-d38e-4250-9248-a3d38205c0aa

📥 Commits

Reviewing files that changed from the base of the PR and between 0a68dc4 and 13ddc05.

📒 Files selected for processing (8)
  • src/app/callsWidgetWindow.test.js
  • src/app/callsWidgetWindow.ts
  • src/app/views/pluginsPopUps.test.js
  • src/app/views/pluginsPopUps.ts
  • src/app/views/webContentEvents.test.js
  • src/app/views/webContentEvents.ts
  • src/app/views/webContentEventsCommon.test.ts
  • src/app/views/webContentEventsCommon.ts

Comment thread src/app/views/pluginsPopUps.ts
@devinbinnie
devinbinnie merged commit 7cfa731 into release-6.2 Jul 31, 2026
23 checks passed
@devinbinnie
devinbinnie deleted the MM-68968_cherrypick_release-6.2 branch July 31, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants