[MM-68968] Guard redirects and subframe navigations alongside will-navigate (#3927) - #3929
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/views/pluginsPopUps.ts`:
- Line 65: Replace the will-frame-navigate handler registration in the plugin
popup setup with popup-specific logic that resolves the originating server for
parentId, allows subframe URLs only when their origin matches that server, and
blocks while logging all other URLs. Update the corresponding plugin popup test
to assert that an HTTPS URL from a different origin is rejected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2a003a32-d38e-4250-9248-a3d38205c0aa
📒 Files selected for processing (8)
src/app/callsWidgetWindow.test.jssrc/app/callsWidgetWindow.tssrc/app/views/pluginsPopUps.test.jssrc/app/views/pluginsPopUps.tssrc/app/views/webContentEvents.test.jssrc/app/views/webContentEvents.tssrc/app/views/webContentEventsCommon.test.tssrc/app/views/webContentEventsCommon.ts
Cherry-pick of #3927 to
release-6.2Change Impact: 🟡 Medium
Regression Risk: Navigation behavior changes across multiple web contents and popup modules. Automated tests cover main-frame and subframe redirects, which limits regression risk.
QA Recommendation: Skip manual QA. Automated coverage is sufficient for this isolated navigation change.
Generated by CodeRabbitAI