Skip to content

[MM-63260] rerequest pull - Fixed comments select text under each card - issue #63 - #191

Closed
peetCreative wants to merge 2 commits into
mattermost:mainfrom
peetCreative:main
Closed

[MM-63260] rerequest pull - Fixed comments select text under each card - issue #63#191
peetCreative wants to merge 2 commits into
mattermost:mainfrom
peetCreative:main

Conversation

@peetCreative

@peetCreative peetCreative commented May 8, 2026

Copy link
Copy Markdown

See #102 (comment)

just added suggestion.

Change Impact: 🟢 Low

Regression Risk: Minimal regression risk. The change is a purely CSS-only modification adding user-select: text; to the .comment-markdown > * selector. This enables text selection for rendered markdown content in comments. No component logic, state management, or data flow is affected. The change does not introduce any untested code paths. Tests exist for the comment component, providing some coverage verification.

QA Recommendation: Minimal manual QA required. Verify that comment text and markdown content can be properly selected/highlighted by users. Confirm that copy-paste functionality works as expected. Visually inspect comments to ensure no unintended styling changes or rendering issues occur. Since this is an isolated CSS property addition affecting only user interaction with text, automated snapshot or visual regression tests would be sufficient if available.

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 40fad4ff-d0ed-461f-9eae-5aef38cf7340

📥 Commits

Reviewing files that changed from the base of the PR and between 7b0a3d1 and 3b72069.

📒 Files selected for processing (1)
  • webapp/src/components/cardDetail/comment.scss

📝 Walkthrough

Walkthrough

The PR adds a single CSS property user-select: text to the .comment-markdown > * selector, enabling text selection on rendered markdown content within comment cards.

Changes

Comment Markdown Text Selection

Layer / File(s) Summary
Styling
webapp/src/components/cardDetail/comment.scss
Added user-select: text declaration to allow text selection on direct children of .comment-markdown container.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing comment text selection under cards by modifying CSS styling. It includes the issue reference and is specific about the problem being solved.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Stylelint (17.10.0)
webapp/src/components/cardDetail/comment.scss

ConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option?
at getModulePath (file:///usr/local/lib/node_modules/stylelint/lib/utils/getModulePath.mjs:29:9)
at loadExtendedConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:280:21)
at extendConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:247:25)
at augmentConfigBasic (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:84:26)
at augmentConfigFull (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:137:30)
at getConfigForFile (file:///usr/local/lib/node_modules/stylelint/lib/getConfigForFile.mjs:102:32)
at async resolveOptionValue (file:///usr/local/lib/node_modules/stylelint/lib/utils/resolveOptionValue.mjs:27:24)
at async standalone (file:///usr/local/lib/node_modules/stylelint/lib/standalone.mjs:127:22)

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattermost-build

Copy link
Copy Markdown
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@peetCreative

Copy link
Copy Markdown
Author

This was solved here. 6e90b8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants