[MM-63260] rerequest pull - Fixed comments select text under each card - issue #63 - #191
[MM-63260] rerequest pull - Fixed comments select text under each card - issue #63#191peetCreative wants to merge 2 commits into
Conversation
Issue documented here: mattermost#63
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds a single CSS property ChangesComment Markdown Text Selection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.10.0)webapp/src/components/cardDetail/comment.scssConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option? Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
This was solved here. 6e90b8d |
See #102 (comment)
just added suggestion.
Change Impact: 🟢 Low
Regression Risk: Minimal regression risk. The change is a purely CSS-only modification adding
user-select: text;to the.comment-markdown > *selector. This enables text selection for rendered markdown content in comments. No component logic, state management, or data flow is affected. The change does not introduce any untested code paths. Tests exist for the comment component, providing some coverage verification.QA Recommendation: Minimal manual QA required. Verify that comment text and markdown content can be properly selected/highlighted by users. Confirm that copy-paste functionality works as expected. Visually inspect comments to ensure no unintended styling changes or rendering issues occur. Since this is an isolated CSS property addition affecting only user interaction with text, automated snapshot or visual regression tests would be sufficient if available.