Automated cherry pick of #217 - #233
Merged
avasconcelos114 merged 1 commit intoJul 16, 2026
Merged
Conversation
….json (#217) * [MM-69594] Write resolved manifest (with version) into bundled plugin.json The bundle Makefile target copied the source plugin.json verbatim, which has no version field, so released boards bundles shipped a plugin.json without a version. Add a `dist` subcommand to the manifest tool that writes the resolved manifest (with the build-time version and release notes URL) into the bundle directory, and use it in the bundle target, matching the playbooks / starter-template pattern. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69594] Add tests for manifest dist subcommand Refactor distManifest to accept the destination directory as a parameter for testability, and add tests covering manifest distribution and the build-time version fallback in findManifest. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69594] Expand manifest tests for version and release-notes resolution Cover the latest-tag fallback, release-notes URL generation, the version-already-present path, and an end-to-end regression test that the repo source plugin.json (which ships without a version) yields a versioned plugin.json in the bundle. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Document sequential test ordering for writeTempManifest helpers Add comments noting that tests using writeTempManifest or mutating process-wide cwd/build vars must not call t.Parallel(). Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com> (cherry picked from commit 162e5a5)
mattermost-build
added
AutomatedCherryPick
Changelog/Not Needed
Docs/Not Needed
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
avasconcelos114
self-requested a review
July 16, 2026 08:31
avasconcelos114
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #217 on release-9.3.
/cc @cursor[bot]