Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,27 @@
"type": "text",
"help_text": "Set this [API token](https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html) to get notified for confluence events when the user triggering the event is not connected to Confluence.\n**Note:** API token should be created using an admin Confluence account. Otherwise, the notification will not be delivered for the spaces/pages user does not have access.",
"secret": true
},
{
"key": "ConfluenceURL",
"display_name": "Confluence URL",
"type": "text",
"help_text": "Configured via the /confluence install setup command. Declared here so it is redacted from support packets.",
"secret": true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support packets typically mask sensitive information - like API tokens and secrets - while keeping data useful for troubleshooting issues unmasked. Therefore, it might only be necessary to mask ConfluenceOAuthClientSecret in this case.

This seems to be the standard pattern followed in the sanitized_config.json file generated with support packets. If there are other reasons to mask the URL and client ID, please feel free to ignore my comment :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
{
"key": "ConfluenceOAuthClientID",
"display_name": "Confluence OAuth Client ID",
"type": "text",
"help_text": "Configured via the /confluence install cloud setup command. Declared here so it is redacted from support packets.",
"secret": true
},
{
"key": "ConfluenceOAuthClientSecret",
"display_name": "Confluence OAuth Client Secret",
"type": "text",
"help_text": "Configured via the /confluence install cloud setup command. Declared here so it is redacted from support packets.",
"secret": true
}
]
}
Expand Down
Loading