Make Document.Info members mutable #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on a project that requires lots of individual mutation of the entire Document structure, and I couldn't find a particular reason why all the Document.Info fields are immutable. The rest of the structure seems to be mutable and I couldn't find a particular reason why these members need to be immutable. Wondering if there's something I'm overlooking. Thanks so much for this awesome package 😀
|
I've always preferred an explicitly immutable style of programming so I wrote much of OpenAPIKit with that bias. I've since introduced vars in many places as you noted to make things more ergonomic in Swift so the changes you are proposing here look good to me. |
mattpolzin
approved these changes
Jan 18, 2025
|
Awesome! I also generally tend towards immutability-by-default, but SwiftUI bindings have led me to generally prefer mutability-by-default in Swift, which has the nice side effect of being somewhat self-documenting in terms of which properties are computed/derived. |
wwalexander
added a commit
to wwalexander/OpenAPIKit
that referenced
this pull request
Jan 19, 2025
I realized there are addtional immutable properties within the Document structure that I didn't address in mattpolzin#390, specifically those of Contact and Route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project that requires lots of individual mutation of the entire Document structure, and I couldn't find a particular reason why all the Document.Info fields are immutable. The rest of the Document structure seems to be mutable. Wondering if there's something I'm overlooking. Thanks so much for this awesome package 😀