Skip to content

Fix save with multifile=True not saving separate subconfigs for items in a list - #779

Merged
mauvilsa merged 2 commits into
mainfrom
issue-777-save-multifile-list
Oct 8, 2025
Merged

mauvilsa merged 2 commits into
mainfrom
issue-777-save-multifile-list

Conversation

@mauvilsa

@mauvilsa mauvilsa commented Oct 3, 2025 •

Copy link
Copy Markdown
Owner

What does this PR do?

Fixes #777

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Oct 3, 2025
@codecov

codecov Bot commented Oct 3, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b4ff170) to head (d389da9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6987      6998   +11     
=========================================
+ Hits          6987      6998   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2025

Copy link
Copy Markdown

@mauvilsa
mauvilsa merged commit 89b50d3 into main Oct 8, 2025
31 checks passed
@mauvilsa
mauvilsa deleted the issue-777-save-multifile-list branch October 8, 2025 04:13

This branch was previously deployed

2 inactive deployments
codecov — d389da95 Deployed Oct 8, 2025 by mauvilsa via codecov #418
sonarcloud — d389da95 Deployed Oct 8, 2025 by mauvilsa via sonarcloud #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArgumentParser.save(multifile=True) does not check list.

1 participant