Skip to content

Fix omegaconf parser mode failing on spawned processes - #784

Merged
mauvilsa merged 1 commit into
mainfrom
pl-issue-21277-spawn-omegaconf
Oct 13, 2025
Merged

mauvilsa merged 1 commit into
mainfrom
pl-issue-21277-spawn-omegaconf

Conversation

@mauvilsa

Copy link
Copy Markdown
Owner

What does this PR do?

Fixes Lightning-AI/pytorch-lightning#21277

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Oct 13, 2025
@codecov

codecov Bot commented Oct 13, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2fd10c6) to head (8fe3d86).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #784   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         7059      7060    +1     
=========================================
+ Hits          7059      7060    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

Copy link
Copy Markdown

@mauvilsa
mauvilsa merged commit fcff962 into main Oct 13, 2025
31 checks passed
@mauvilsa
mauvilsa deleted the pl-issue-21277-spawn-omegaconf branch October 13, 2025 06:12

This branch was previously deployed

2 inactive deployments
sonarcloud — 8fe3d869 Deployed Oct 13, 2025 by mauvilsa via sonarcloud #425
codecov — 8fe3d869 Deployed Oct 13, 2025 by mauvilsa via codecov #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SaveConfigCallback does not work as expected and raises an error under specific settings (DDPStrategy start_method="spawn")

1 participant