Skip to content

Conversation

DonLakeFlyer
Copy link
Contributor

Fix #13403

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lowers the minimum transect spacing threshold from 0.5 meters to 0.3 meters in survey planning functionality to provide more granular control over mission planning.

  • Changed minimum transect spacing validation from 0.5m to 0.3m
  • Updated corresponding comments to reflect the new minimum value

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/MissionManager/SurveyComplexItem.cc Updated minimum grid spacing threshold and comment
src/MissionManager/CorridorScanComplexItem.cc Updated minimum transect spacing threshold and comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HTRamsey
Copy link
Collaborator

HTRamsey commented Sep 24, 2025

Not that it matters that much but I would put static constexpr double _minimumSpacing = 0.3 in TransectStyleComplexItem

@DonLakeFlyer
Copy link
Contributor Author

Yeah, makes sense

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DonLakeFlyer DonLakeFlyer merged commit 7ca60bc into master Sep 28, 2025
18 checks passed
@DonLakeFlyer DonLakeFlyer deleted the ScanSpacing branch September 28, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Survey Spacing" lower limit to be "0.3 m" - good for lawn mower plans
2 participants