fix(AnalyzeView): fall back to message transport when vehicle NAKs FTP list-with-time (cherry-pick to Stable_V5.1) - #14861
Merged
DonLakeFlyer merged 1 commit intoAug 13, 2026
Conversation
…P list-with-time PX4 <= 1.17 NAKs kCmdListDirectoryWithTime so FTP directory listings carry no modification times, leaving all logs with an unknown date. When FTPManager reports the NAK, fall back to the message based transport where LOG_ENTRY reports the log dates. Fixes mavlink#14789 (cherry picked from commit f1883f9)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Stable_V5.1 #14861 +/- ##
==============================================
Coverage ? 32.81%
==============================================
Files ? 784
Lines ? 67689
Branches ? 31362
==============================================
Hits ? 22212
Misses ? 30544
Partials ? 14933
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 75 failed, 7 skipped. Test Resultslinux-coverage-integration: 37 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-08-13 20:43:57 UTC • Commit: 4685a6d • Triggered by: Android |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14852 (f1883f9) to Stable_V5.1.
Completes the onboard-log date handling already on stable (#14811, #14815): vehicles that NAK the FTP list-with-time opcode now fall back to message transport instead of failing the log listing.