Skip to content

ci(gstreamer): download SDK exclusively from S3 mirror on stable - #14870

Merged
DonLakeFlyer merged 2 commits into
mavlink:Stable_V5.1from
DonLakeFlyer:s3-only-dependencies-stable
Aug 15, 2026
Merged

ci(gstreamer): download SDK exclusively from S3 mirror on stable#14870
DonLakeFlyer merged 2 commits into
mavlink:Stable_V5.1from
DonLakeFlyer:s3-only-dependencies-stable

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Problem

Stable builds pulled the GStreamer SDK from gstreamer.freedesktop.org, meaning upstream packages could change or disappear out from under a stable release.

Change

GStreamer SDK downloads (CMake configure for android/ios/macos/windows, plus the Windows/macOS install-dependencies scripts) now come exclusively from the QGroundControl S3 mirror (dependencies/gstreamer/..., populated by mirror-gstreamer.yml). No public fallback.

  • Integrity is verified against the in-tree pinned SHA256 checksums in .github/build-config.json (all 6 platform packages for 1.28.4 are pinned). The upstream .sha256sum sidecar is not mirrored, so the pin is the sole integrity source; a missing pin is a hard configure error by default (GStreamer_REQUIRE_CHECKSUM=ON).
  • All 6 mirrored 1.28.4 packages verified present on S3.
  • Diff kept deliberately minimal for the stable branch: the now-unused sidecar-fetch helpers (gstreamer_fetch_checksum, _gstreamer_download_sidecar) are left in place to avoid churn.

Stable-branch-only change.

Upstream gstreamer.freedesktop.org packages can change or disappear out
from under a stable release. Download GStreamer SDKs (CMake configure and
install-dependencies scripts) solely from the QGroundControl S3 mirror,
with integrity verified against the in-tree pinned checksums in
.github/build-config.json.
curl.se refreshed the CA bundle upstream; the old pin fails every iOS
configure. New hash verified against curl.se's published .sha256.
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Aug 15, 2026
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Stable_V5.1@ecb0691). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             Stable_V5.1   #14870   +/-   ##
==============================================
  Coverage               ?   32.82%           
==============================================
  Files                  ?      784           
  Lines                  ?    67689           
  Branches               ?    31362           
==============================================
  Hits                   ?    22217           
  Misses                 ?    30534           
  Partials               ?    14938           
Flag Coverage Δ
unittests 32.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb0691...7ec3a2d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 75 failed, 7 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 121 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 121 passed, 0 skipped
Total: 299 passed, 0 skipped

Code Coverage

Coverage: 69.6%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 252.26 MB
QGroundControl-aarch64 176.30 MB
QGroundControl-installer-AMD64 137.82 MB
QGroundControl-installer-AMD64-ARM64 80.34 MB
QGroundControl-installer-ARM64 109.08 MB
QGroundControl-linux 84.31 MB
QGroundControl-mac 84.31 MB
QGroundControl-x86_64 188.52 MB
No baseline available for comparison

Updated: 2026-08-15 18:52:46 UTC • Commit: 7ec3a2d • Triggered by: Android

@DonLakeFlyer
DonLakeFlyer merged commit c26663e into mavlink:Stable_V5.1 Aug 15, 2026
49 of 50 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the s3-only-dependencies-stable branch August 15, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake github_actions Pull requests that update GitHub Actions code RN: IMPROVEMENT size/XS Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant