Skip to content

fix(FirmwarePlugin): keep enum sentinel values outside param operating range (Stable_V5.1) - #14871

Merged
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:enum-sentinel-stable
Aug 15, 2026
Merged

fix(FirmwarePlugin): keep enum sentinel values outside param operating range (Stable_V5.1)#14871
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:enum-sentinel-stable

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Stable backport of #14868 (fix for #14854).

Clean cherry-pick of 188a5cb. Verified locally on Stable_V5.1: build succeeds and APMParameterMetaDataTest passes.

…g range

Validate enum codes against the storage type only instead of the full
metadata, so firmware-declared sentinels (e.g. RTL_CONE_SLOPE 0=Disabled
with range 0.5..10) are no longer dropped from the parameter editor.

Fixes mavlink#14854

(cherry picked from commit 188a5cb)
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Stable_V5.1@ecb0691). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/FirmwarePlugin/ParameterMetaData.cc 0.00% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             Stable_V5.1   #14871   +/-   ##
==============================================
  Coverage               ?   32.78%           
==============================================
  Files                  ?      784           
  Lines                  ?    67690           
  Branches               ?    31363           
==============================================
  Hits                   ?    22195           
  Misses                 ?    30582           
  Partials               ?    14913           
Flag Coverage Δ
unittests 32.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/FirmwarePlugin/ParameterMetaData.cc 48.36% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb0691...3448238. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 75 failed, 7 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 121 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 121 passed, 0 skipped
Total: 299 passed, 0 skipped

Code Coverage

Coverage: 69.5%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 252.26 MB
QGroundControl-aarch64 176.30 MB
QGroundControl-installer-AMD64 137.81 MB
QGroundControl-installer-AMD64-ARM64 80.35 MB
QGroundControl-installer-ARM64 109.10 MB
QGroundControl-linux 84.32 MB
QGroundControl-mac 84.31 MB
QGroundControl-x86_64 188.51 MB
No baseline available for comparison

Updated: 2026-08-15 19:02:22 UTC • Commit: 3448238 • Triggered by: Linux

@DonLakeFlyer
DonLakeFlyer merged commit 118296d into mavlink:Stable_V5.1 Aug 15, 2026
52 of 55 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the enum-sentinel-stable branch August 15, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant