(User) add logout button and authorization check #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfarseer
requested changes
Aug 9, 2018
src/actions/UserActions.js
Outdated
| type: LOGIN_STATUS_REQUEST, | ||
| }) | ||
|
|
||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
я добавил в .eslintrc globals VK, теперь можно не выключать строку
There was a problem hiding this comment.
очень странно, не работает у меня "globals": { "VK": true }, хотя правила работают и плагин Eslint для VSCode тоже нормально срабатывает
src/actions/UserActions.js
Outdated
| dispatch({ | ||
| type: LOGOUT_REQUEST, | ||
| }) | ||
| // eslint-disable-next-line no-undef |
| const { name, handleLogout, handleLogin, isFetching } = this.props | ||
| const authorized = Boolean(name) | ||
| const btnName = authorized ? 'Выйти' : 'Войти' | ||
| const onClick = authorized ? handleLogout : handleLogin |
src/reducers/user.js
Outdated
| return { ...state, isFetching: false, error: action.payload.message } | ||
|
|
||
| case t.LOGIN_STATUS_REQUEST: | ||
| return { ...state, isFetching: true, error: '' } |
There was a problem hiding this comment.
можно объединить одинаковые case, например:
case t.LOGIN_REQUEST:
case t.LOGIN_STATUS_REQUEST:
case t.LOGOUT_REQUEST:
return { ...state, isFetching: true, error: '' }p.s. так же посмотри остальные
There was a problem hiding this comment.
good point.
у redux-actions вроде нельзя так сделать, не помнишь ?
src/reducers/user.js
Outdated
| return { ...state, isFetching: true, error: '' } | ||
|
|
||
| case t.LOGIN_STATUS_SUCCESS: | ||
| return { ...state, isFetching: false, error: '', name: action.payload } |
There was a problem hiding this comment.
я думаю, что если мы на *_REQUEST обнуляем ошибку, то на *_SUCCESS ее уже быть не может и поэтому можно удалить лишний код: error: ''
…rse-ru-v2 into art/login-btn-fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.