-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CY6C65215 and CY6C65215A #5
base: master
Are you sure you want to change the base?
Conversation
pass # TODO verbose output | ||
else: | ||
match(type): | ||
case CyType.UART_CDC: # TODO we could have two of these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to handle this case a little bit better in this function. I think what would make sense would be to add two DiscoveredDevice entries to the output when we see a dual channel device. Either that, or make DiscoveredDevice able to hold two different channels from one device.
I tried running
|
Hmmm - I'll look into this. I have worked on it in the last few days, and it's working on my side. But I have more changes I've done, so probably I've fixed this issue already. |
Hey! Finally had time to work on this! I set up a new test suite in the code to test device discovery. This lets you define what the USB descriptors for a device look like, and then test scanning for those descriptors. If you can add entries in there based on your dual channel device (ideally for every combination of interfaces, e.g. UART+UART, UART+I2C, I2C+SPI, etc), then we can test the device discovery code waaay more easily. To generate the USB descriptor in the test, I am getting data from this script I wrote that dumps all the USB descriptors on the machine. But you could also use something like NirSoft USBTreeView on Windows. P.S. do you have a Discord account? I can add you to the Mbed CE discord server and we can discuss this more! P.P.S. I got the tracking email for your package but it still hasn't arrived yet sadly. |
Support the dual channel devices. This is still a WIP.
This PR is to discuss the necessary changes to the scb_context, which are quite extensive.
Discussion on this topic also in PR #2