Skip to content

Paths params that are parsed from the incoming req.url, do not apply URI decoding to extracted values #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sam152 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Paths params that are parsed from the incoming req.url, do not apply URI decoding to extracted values #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add2a69
Progress
Sam152 Jun 2, 2026
e91e7ab
Remove idea
Sam152 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/adapters/node-http/procedures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ export const createProcedureCache = (router: OpenApiRouter) => {
}

const procedure = procedureMethodCache.get(procedureRegExp);
const pathInput = procedureRegExp.exec(path)?.groups ?? {};
const pathInput = Object.fromEntries(
Object.entries(procedureRegExp.exec(path)?.groups ?? {}).map(([key, value]) => [
key,
decodeURIComponent(value),
]),
);

return { procedure, pathInput };
};
Expand Down
32 changes: 32 additions & 0 deletions test/adapters/express.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ describe('express adapter', () => {
.input(z.object({ name: z.string() }))
.output(z.object({ greeting: z.string() }))
.query(({ input }) => ({ greeting: `Hello ${input.name}!` })),
sayHelloWithParam: t.procedure
.meta({ openapi: { method: 'GET', path: `/say-hello-with-param/{name}` } })
.input(z.object({ name: z.string() }))
.output(z.object({ greeting: z.string() }))
.query(({ input }) => ({ greeting: `Hello ${input.name}!` })),
});

const { url, close } = createExpressServerWithRouter({
Expand Down Expand Up @@ -111,6 +116,33 @@ describe('express adapter', () => {
expect(createContextMock).toHaveBeenCalledTimes(1);
expect(responseMetaMock).toHaveBeenCalledTimes(1);
expect(onErrorMock).toHaveBeenCalledTimes(0);

clearMocks();
}
{
const res = await fetch(`${url}/say-hello-with-param/Lily`, { method: 'GET' });

expect(res.status).toBe(200);
expect(await res.json()).toEqual({ greeting: 'Hello Lily!' });
expect(createContextMock).toHaveBeenCalledTimes(1);
expect(responseMetaMock).toHaveBeenCalledTimes(1);
expect(onErrorMock).toHaveBeenCalledTimes(0);

clearMocks();
}

{
const res = await fetch(`${url}/say-hello-with-param/${encodeURIComponent('Li::ly')}`, {
method: 'GET',
});

expect(res.status).toBe(200);
expect(await res.json()).toEqual({ greeting: 'Hello Li::ly!' });
expect(createContextMock).toHaveBeenCalledTimes(1);
expect(responseMetaMock).toHaveBeenCalledTimes(1);
expect(onErrorMock).toHaveBeenCalledTimes(0);

clearMocks();
}

close();
Expand Down