Skip to content

accelerate: Fix C type errors for GCC 14/Clang compatibility #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fweimer-rh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

accelerate: Fix C type errors for GCC 14/Clang compatibility #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe0fab
accelerate: Fix type of PyArray_FillWithScalar
fweimer-rh Jan 5, 2024
f62dd58
accelerate: Use recommended way to integrate NumPy with Cython
fweimer-rh Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions accelerate/src/numpy_formathandler.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ cdef extern from "numpy/arrayobject.h":
int PyArray_ISCARRAY_RO( np.ndarray instance )
cdef np.ndarray PyArray_Zeros(int nd, np.Py_intptr_t* dims, np.dtype, int fortran)
cdef np.ndarray PyArray_EnsureArray(object)
cdef int PyArray_FillWithScalar(object, object)
cdef void import_array()
cdef int PyArray_FillWithScalar(np.ndarray, object)
cdef void* PyArray_DATA( np.ndarray )
cdef int PyArray_NDIM( np.ndarray )
cdef int *PyArray_DIMS( np.ndarray )
Expand Down Expand Up @@ -226,4 +225,4 @@ cdef class NumpyHandler(FormatHandler):

# Cython numpy tutorial neglects to mention this AFAICS
# get segfaults without it
import_array()
np.import_array()