Fix FTBFS with Cython 3.1.x #156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython 3.1.0 has removed support for Python 2, which includes the 'long' data type. Simply switch to 'int' which should be the same thing in Python 3.
|
Doing this without updating the requirements seems like a bad idea to me. unless it actually does work with python2 -- I don't suppose you tested it? So I think #155 is the better option. |
Contributor
Author
|
No, I didn't test Python 2. Fair enough, but I would rebase/squash the commits in your PR as it has a lot of extra cruft that is done and undone. The resulting changes look fine, though. |
|
well, yes, it should be squashed when merged ... |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython 3.1.0 has removed support for Python 2, which includes the 'long' data type. Simply switch to 'int' which should be the same thing in Python 3.