feat(tests): adopt test output helpers for diagnostic logging #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ITestOutputHelper to xUnit unit tests (ProgramTests, ClaudeMonitorTests) - add IReqnrollOutputHelper to Reqnroll step definitions (E2E, System, Hook tests) - update GlobalUsings.cs in all test projects with required namespaces - add test output helper guidance to coding standards - update code review checklist with test output helper requirement Refs: #120 Co-Authored-By: Claude Opus 4.5 <[email protected]>
No Plan File DetectedThis PR does not modify any plan files. If this work is tracked by a plan, please update the relevant plan file in |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
martincjarvis
approved these changes
Jan 15, 2026
Collaborator
martincjarvis
left a comment
martincjarvis
left a comment
There was a problem hiding this comment.
Code Review: PR #121
Reviewer: martincjarvis
Summary
Adds ITestOutputHelper and IReqnrollOutputHelper to all test projects for diagnostic output visibility in test runners.
Review Checklist
- Follows coding standards (constructor injection, readonly fields,
_outputnaming) - Consistent implementation pattern across all 4 test projects
- All 122 tests pass on ubuntu, windows, macos
- GlobalUsings.cs updated with required namespaces
- Coding standards documentation updated with guidance and examples
- Code review checklist updated with new requirement
- No security concerns
Observations
- praise: Clean, consistent pattern - constructor injection with diagnostic
WriteLinecalls - praise: Good documentation with examples for both xUnit and Reqnroll patterns
- praise: Refactored duplicate
GivenIAmOnABranchto delegate toGivenIAmOnTheBranch
Verdict
APPROVED ✓
All checks pass. Ready for auto-merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ITestOutputHelperto xUnit unit tests for per-test diagnostic outputIReqnrollOutputHelperto all Reqnroll step definitions (E2E, System, Hook tests)GlobalUsings.csin all test projects with required namespacesTest Plan
Refs: #120
🤖 Generated with Claude Code