-
Notifications
You must be signed in to change notification settings - Fork 242
[Feat] Make themes public #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2026-01-14 11:05:53 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/ |
for more information, see https://pre-commit.ci
…/vizro into feat/make-themes-public
|
@antonymilne - now that I've written everything anyway, I am wondering whether we should just make it public even though the color palettes might change in the future 🤔 |
for more information, see https://pre-commit.ci
stichbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just a few comments. Would love to see some graphics in the themes.md to illustrate the different types of qualitative/sequential/diverging palettes etc, so it's easy to see what is on offer.
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
|
FYI I plan to review this after we've reviewed and merged https://github.com/McK-Internal/vizro-internal/pull/2347 🙂 We can make any similar required changes on your PR here once we're happy with that internal PR. |
…ardize naming - Rename colors.py, palettes.py, templates.py, static_template_generator.py to use underscore prefix (_colors.py, etc.) - Move create_template_common() from _templates.py to _static_template_generator.py where it's used - Update all imports to use private module names - Change grey to gray (American spelling) for consistency with vizro_mck - Update hatch.toml paths to reflect new module locations
for more information, see https://pre-commit.ci
- Move PYTHONPATH configuration from hatch.toml to pyproject.toml - Add tools directory to pytest pythonpath for cleaner test imports - Remove sys.path manipulation from test_generate_templates.py - Update test imports to use direct import from generate_templates
for more information, see https://pre-commit.ci
- Add comment explaining PYTHONPATH needed for gunicorn (pytest pythonpath only affects pytest) - Restore PYTHONPATH in hatch.toml for e2e test gunicorn processes - Keep pytest pythonpath in pyproject.toml for test discovery
|
Generally looks great 💯 I did a small bit of tidying but didn't change anything major. The most important changes to be aware of are:
I've put this back into draft and the ticket as blocked by https://github.com/McK-Internal/vizro-internal/issues/2293. When that's done, here's what remains for @antonymilne and @huong-li-nguyen:
I thought about whether we should release this as a separate Python package and version separately and decided not to - let's release as part of Vizro, as done here. |
|
Sounds great and I agree with everything! 🚀 Just this point I am less sure about:
I don't know if you saw my comment in the other repo, but I kind of like the current visual for the sequential palettes as well (optimally, they should have the name of the colors inside the squares too). This way our users could easily do subsets of the sequential sequences without having to refer to the source code (@lingyielia use case, where she wanted more contrast and just took X out of the 16 colors inside the sequential palette). But I do think that the spectrum visual is correct for continuous scales, maybe let's ask @stephkaiser for the final visuals in the end 👍 |
|
Yes I saw your comment and replied with this:
So unless @stephkaiser disagrees I think we should go for the continuous spectrum visuals for the continuous palettes. |
Description
Closes https://github.com/McK-Internal/vizro-internal/issues/2330
hatch run generate-color-imagesUsage
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":