-
Notifications
You must be signed in to change notification settings - Fork 242
[Docs] Implement mkdocstring to automatically create pydantic docsstrings #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxschulz-COL
wants to merge
32
commits into
main
Choose a base branch
from
docs/mkdocstring_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3e7fe4d
First working version, with REUSABLE VALIDATORS COMMENTED OUT
maxschulz-COL 7581ebf
Add example model from the griffe docs: WHY IS IT NOT THE SAME OUTCOM…
maxschulz-COL 0439656
Removal of all docstring sections - sadly e.g. fields without Field +…
maxschulz-COL c4ac82e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 68fd333
Move example model to actual models
maxschulz-COL 19c9250
Filter for private attributes and private validators
maxschulz-COL 8f5e935
make validators have hyperlinks through docstring
maxschulz-COL 655d5f7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aeb2f83
Clean up defaults
maxschulz-COL ad619df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 945a664
Merge branch 'main' into docs/mkdocstring_2
maxschulz-COL 51495b6
Changelog
maxschulz-COL d47df22
Remove example model
maxschulz-COL 24b6116
UPdated schema
maxschulz-COL 2c3bf3c
Add back the commented out validators
maxschulz-COL 766f7da
Minimal version black
maxschulz-COL 5330322
Update vizro-core/docs/griffe_extensions.py
maxschulz-COL e7c5244
Small cleanup
maxschulz-COL 166f1ed
Merge branch 'main' into docs/mkdocstring_2
maxschulz-COL c7a8d61
removing docstrings also from actions
maxschulz-COL 38507fc
Use template overwrite
maxschulz-COL 354f6f3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 14689c4
Fix autorefs
maxschulz-COL df93729
Merge branch 'docs/mkdocstring_2' of github.com:mckinsey/vizro into d…
maxschulz-COL cade86c
Schema
maxschulz-COL 4392f59
Remove constants
maxschulz-COL d7376e5
Linter
maxschulz-COL cf094eb
Merge branch 'main' into docs/mkdocstring_2
maxschulz-COL 14c7a5b
Update vizro-core/docs/griffe_extensions.py
maxschulz-COL 8343251
Merge branch 'main' into docs/mkdocstring_2
maxschulz-COL a07a429
Checked setting, and removed one logger mention
maxschulz-COL 0578db8
PR comments
maxschulz-COL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,6 +68,7 @@ coverage.xml | |
| .hypothesis/ | ||
| .pytest_cache/ | ||
| cover/ | ||
| .playwright-mcp/ | ||
|
|
||
| # Translations | ||
| *.mo | ||
|
|
||
48 changes: 48 additions & 0 deletions
48
vizro-core/changelog.d/20260120_184040_maximilian_schulz_mkdocstring_2.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <!-- | ||
| A new scriv changelog fragment. | ||
|
|
||
| Uncomment the section that is right (remove the HTML comment wrapper). | ||
| --> | ||
|
|
||
| <!-- | ||
| ### Highlights ✨ | ||
|
|
||
| - A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Removed | ||
|
|
||
| - A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Added | ||
|
|
||
| - A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Changed | ||
|
|
||
| - A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Deprecated | ||
|
|
||
| - A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Fixed | ||
|
|
||
| - A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Security | ||
|
|
||
| - A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) | ||
|
|
||
| --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Constants | ||
|
|
||
| Constants used in Vizro. | ||
|
|
||
| <!-- vale off --> | ||
|
|
||
| ::: vizro._constants.GAP_DEFAULT | ||
|
|
||
| ::: vizro.models._grid.MIN_DEFAULT | ||
|
|
||
| <!-- vale on --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.