[QA] Set control multi select tests #1558

l0uden · 2026-01-26T17:25:33Z

Description

Closes https://github.com/McK-Internal/vizro-internal/issues/2403

Notice

I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

This reverts commit 8795181.

…control_multi_select_tests

github-actions · 2026-01-26T17:29:57Z

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2026-01-27 15:34:08 UTC
Commit: 7987ced

Compare the examples using the commit's wheel file vs the latest released version:

…control_multi_select_tests

Copilot

Pull request overview

This PR adds comprehensive end-to-end tests for the set control multi-select functionality in Vizro. The tests cover various interaction patterns including graph clicks with modifier keys, AgGrid row selection with checkboxes and command/shift keys, button/card triggers, and filtered component interactions.

Changes:

Added new test helper functions for improved path generation and modifier key interactions
Created comprehensive test suite for multi-select set control actions covering graphs, AgGrid tables, buttons, and cards
Added new test pages demonstrating multi-select scenarios including cross-filtering, self-filtering, and filtered triggers
Refactored existing tests to use new helper functions for better maintainability

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
vizro-core/tests/tests_utils/e2e/vizro/paths.py	Added helper functions for AgGrid cell/checkbox paths and scatter point paths (contains critical syntax error)
vizro-core/tests/tests_utils/e2e/vizro/navigation.py	Added modifier_click function for keyboard+mouse interactions
vizro-core/tests/tests_utils/e2e/vizro/constants.py	Added constants for new test pages and components
vizro-core/tests/e2e/vizro/test_screenshots/test_screenshots.py	Refactored to use new table_ag_grid_cell_path_by_row helper
vizro-core/tests/e2e/vizro/test_dom_elements/test_table_ag_grid.py	Refactored to use new path helper functions
vizro-core/tests/e2e/vizro/test_dom_elements/test_dynamic_data.py	Removed redundant select_all_status=False parameters
vizro-core/tests/e2e/vizro/test_dom_elements/test_actions.py	Added 10 new comprehensive tests for multi-select set control functionality
vizro-core/tests/e2e/vizro/dashboards/default/pages/set_control_multi_select_pages.py	Created new test pages with multi-select configurations
vizro-core/tests/e2e/vizro/dashboards/default/dashboard.py	Integrated new test pages into dashboard

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T15:39:35Z

vizro-core/tests/tests_utils/e2e/vizro/paths.py

+
+def table_ag_grid_checkbox_path_by_row(table_id, row_index):
+    """Path to AG Grid table checkbox input by row index."""
+    return f"div[id='{table_id}'] div[row-index='{row_index}']  input.ag-checkbox-input"


There is an extra space in the CSS selector between the two spaces before 'input.ag-checkbox-input'. This should likely be a single space for consistent CSS selector formatting.

Suggested change

return f"div[id='{table_id}'] div[row-index='{row_index}'] input.ag-checkbox-input"

return f"div[id='{table_id}'] div[row-index='{row_index}'] input.ag-checkbox-input"

Copilot · 2026-01-27T15:39:36Z

vizro-core/tests/e2e/vizro/dashboards/default/pages/set_control_multi_select_pages.py

+gapminder = px.data.gapminder()
+
+


The variable 'gapminder' is defined but never used in this file. Consider removing it to keep the code clean.

Suggested change

gapminder = px.data.gapminder()

Copilot · 2026-01-27T15:39:36Z

vizro-core/tests/e2e/vizro/test_dom_elements/test_actions.py

+        selector=table_ag_grid_cell_path_by_row(
+            cnst.TABLE_SET_CONTROL_MULTI_SELECT, row_index=2, col_id="sepal_length"
+        ),
+        key=Keys.COMMAND,


The test uses Keys.COMMAND which is Mac-specific. For cross-platform compatibility, consider using Keys.CONTROL on Windows/Linux or detecting the operating system. This test may fail on non-Mac systems where AgGrid expects CTRL for multi-select rather than CMD.

Copilot · 2026-01-27T15:39:36Z

vizro-core/tests/e2e/vizro/test_dom_elements/test_actions.py

+        selector=table_ag_grid_cell_path_by_row(
+            cnst.TABLE_SET_CONTROL_MULTI_SELECT, row_index=0, col_id="sepal_length"
+        ),
+        key=Keys.COMMAND,


The test uses Keys.COMMAND which is Mac-specific. For cross-platform compatibility, consider using Keys.CONTROL on Windows/Linux or detecting the operating system. This test may fail on non-Mac systems where AgGrid expects CTRL for multi-select rather than CMD.

Copilot · 2026-01-27T15:39:36Z

vizro-core/tests/tests_utils/e2e/vizro/paths.py

+
+
+def scatter_point_path(graph_id, point_number, trace_index=2):
+    return f"div[id='{graph_id}'] g[class^='trace']:nth-of-type({trace_index}) path:nth-of-type({point_number}"


Missing closing parenthesis in the return statement. The f-string is not properly closed.

Suggested change

return f"div[id='{graph_id}'] g[class^='trace']:nth-of-type({trace_index}) path:nth-of-type({point_number}"

return f"div[id='{graph_id}'] g[class^='trace']:nth-of-type({trace_index}) path:nth-of-type({point_number})"

l0uden added 30 commits April 1, 2025 14:32

data frame parameter test

8795181

Revert "data frame parameter test"

69f17b2

This reverts commit 8795181.

Merge branch 'main' of https://github.com/mckinsey/vizro

3134da0

Merge branch 'main' of https://github.com/mckinsey/vizro

b71e210

Merge branch 'main' of https://github.com/mckinsey/vizro

7f01cae

Merge branch 'main' of https://github.com/mckinsey/vizro

e3c7f93

Merge branch 'main' of https://github.com/mckinsey/vizro

008cb72

Merge branch 'main' of https://github.com/mckinsey/vizro

6305456

Merge branch 'main' of https://github.com/mckinsey/vizro

ace4b5b

Merge branch 'main' of https://github.com/mckinsey/vizro

b11ed48

Merge branch 'main' of https://github.com/mckinsey/vizro

ae42e28

Merge branch 'main' of https://github.com/mckinsey/vizro

b8711b5

Merge branch 'main' of https://github.com/mckinsey/vizro

38cebdc

Merge branch 'main' of https://github.com/mckinsey/vizro

4d3464f

Merge branch 'main' of https://github.com/mckinsey/vizro

0cb855a

Merge branch 'main' of https://github.com/mckinsey/vizro

55591e6

Merge branch 'main' of https://github.com/mckinsey/vizro

2bb768e

Merge branch 'main' of https://github.com/mckinsey/vizro

1389c95

Merge branch 'main' of https://github.com/mckinsey/vizro

b10cc9c

Merge branch 'main' of https://github.com/mckinsey/vizro

32287e9

Merge branch 'main' of https://github.com/mckinsey/vizro

242b101

test extra parameter for graph

5ca5573

Merge branch 'main' of https://github.com/mckinsey/vizro

18682c4

Merge branch 'main' of https://github.com/mckinsey/vizro

bd2b546

Merge branch 'main' of https://github.com/mckinsey/vizro

31b8775

Merge branch 'main' of https://github.com/mckinsey/vizro

0f46334

Merge branch 'main' of https://github.com/mckinsey/vizro

a5f9730

Merge branch 'main' of https://github.com/mckinsey/vizro

b8e3790

Merge branch 'main' of https://github.com/mckinsey/vizro

6722cd4

Merge branch 'main' of https://github.com/mckinsey/vizro

3ab01a6

l0uden added 15 commits November 4, 2025 10:28

Merge branch 'main' of https://github.com/mckinsey/vizro

36e96fb

Merge branch 'main' of https://github.com/mckinsey/vizro

873ecce

Merge branch 'main' of https://github.com/mckinsey/vizro

e1aa2b5

Merge branch 'main' of https://github.com/mckinsey/vizro

dadd7ed

Merge branch 'main' of https://github.com/mckinsey/vizro

698c220

Merge branch 'main' of https://github.com/mckinsey/vizro

b3aef82

Merge branch 'main' of https://github.com/mckinsey/vizro

ad7d1a5

Merge branch 'main' of https://github.com/mckinsey/vizro

437fb3e

Merge branch 'main' of https://github.com/mckinsey/vizro

673b815

Merge branch 'main' of https://github.com/mckinsey/vizro

d6d16df

Merge branch 'main' of https://github.com/mckinsey/vizro

b93b318

Merge branch 'main' of https://github.com/mckinsey/vizro

2bd704b

basic scenarios

3f8ffa0

all scenarios

8c564d1

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/set_…

3aadc50

…control_multi_select_tests

l0uden added 4 commits January 27, 2026 15:52

refactoring and screenshots

85285fd

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/set_…

4ec9926

…control_multi_select_tests

fix tests

c5a73e8

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/set_…

7987ced

…control_multi_select_tests

l0uden marked this pull request as ready for review January 27, 2026 15:33

l0uden requested review from Joseph-Perkins, antonymilne, huong-li-nguyen, lingyielia and maxschulz-COL as code owners January 27, 2026 15:33

Copilot AI review requested due to automatic review settings January 27, 2026 15:33

Copilot started reviewing on behalf of l0uden January 27, 2026 15:34 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

petar-qb assigned l0uden Jan 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QA] Set control multi select tests #1558

[QA] Set control multi select tests #1558

Uh oh!

l0uden commented Jan 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return f"div[id='{table_id}'] div[row-index='{row_index}'] input.ag-checkbox-input"
	return f"div[id='{table_id}'] div[row-index='{row_index}'] input.ag-checkbox-input"



		def scatter_point_path(graph_id, point_number, trace_index=2):
		return f"div[id='{graph_id}'] g[class^='trace']:nth-of-type({trace_index}) path:nth-of-type({point_number}"

[QA] Set control multi select tests #1558

Are you sure you want to change the base?

[QA] Set control multi select tests #1558

Uh oh!

Conversation

l0uden commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notice

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

View the example dashboards of the current commit live on PyCafe ☕ 🚀

vizro-core/examples/scratch_dev

vizro-core/examples/dev/

vizro-core/examples/visual-vocabulary/

vizro-core/examples/tutorial/

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

l0uden commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading