bootutil: Move primary/secondary slot definition to bootutil_public - enum #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
reviewed
Aug 20, 2025
Comment on lines
133
to
135
| #define BOOT_PRIMARY_SLOT 0 | ||
| #define BOOT_SECONDARY_SLOT 1 | ||
| #define BOOT_SLOT_COUNT 2 |
There was a problem hiding this comment.
Ok, added the enum, this resulted in a lot of changes needed changing uint32_t -> enum boot_slot
ahasztag
force-pushed
the
move_slots_definition_to_public
branch
from
c551e45 to
91cefd3
Compare
ahasztag
force-pushed
the
move_slots_definition_to_public
branch
from
91cefd3 to
6e7c4eb
Compare
ahasztag
force-pushed
the
move_slots_definition_to_public
branch
2 times, most recently
from
0776cbf to
30c27c5
Compare
The slots definitions (BOOT_PRIMARY_SLOT, BOOT_SECONDARY_SLOT) were defined in bootutil_priv.h, which made them unusable for bootloader requests. This commit moves them to bootutil_public.h Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
move_slots_definition_to_public
branch
from
30c27c5 to
0d6ba96
Compare
nordicjm
reviewed
Aug 21, 2025
Comment on lines
-6
to
+7
| - `CONFIG_MCUBOOT_PRIMARY_SLOT_PATH`: MTD partition for the application firmware image PRIMARY slot; | ||
| - `CONFIG_MCUBOOT_SECONDARY_SLOT_PATH`: MTD partition for the application firmware image SECONDARY slot; | ||
| - `CONFIG_MCUBOOT_SLOT_PRIMARY_PATH`: MTD partition for the application firmware image PRIMARY slot; | ||
| - `CONFIG_MCUBOOT_SLOT_SECONDARY_PATH`: MTD partition for the application firmware image SECONDARY slot; |
There was a problem hiding this comment.
this would be a breaking change so next release would need major version increment @d3zd3z
nordicjm
approved these changes
Aug 21, 2025
ahasztag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slots definitions (BOOT_PRIMARY_SLOT, BOOT_SECONDARY_SLOT) were defined in bootutil_priv.h, which made them unusable for bootloader requests. This commit moves them to bootutil_public.h