imgtool: Fixed str and int concat in key loading exceptions #2436
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmasar
changed the title
fundakol
reviewed
Sep 1, 2025
| if isinstance(pk, RSAPrivateKey): | ||
| if pk.key_size not in RSA_KEY_SIZES: | ||
| raise Exception("Unsupported RSA key size: " + pk.key_size) | ||
| raise Exception("Unsupported RSA key size: " + str(pk.key_size)) |
There was a problem hiding this comment.
Should be done in more pythoning way with fstring formatting like:
raise Exception(f"Unsupported RSA key size: {pk.key_size}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is string and int concatenation in handling unsupported key types which is leading to incorrect application crash.