Skip to content

variable "sigterm" must be volatile sig_atomic_t #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crrodriguez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

variable "sigterm" must be volatile sig_atomic_t #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Grow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2984,7 +2984,7 @@
return 0;
}

int sigterm = 0;
volatile sig_atomic_t sigterm = 0;

Check failure on line 2987 in Grow.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING:VOLATILE: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst

Check failure on line 2987 in Grow.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
static void catch_term(int sig)
{
sigterm = 1;
Expand Down
2 changes: 1 addition & 1 deletion mdmon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

int mon_tid, mgr_tid;

int sigterm;
volatile sig_atomic_t sigterm;

Check failure on line 77 in mdmon.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING:VOLATILE: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst

#ifdef USE_PTHREADS
static void *run_child(void *v)
Expand Down
2 changes: 1 addition & 1 deletion mdmon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
void remove_pidfile(char *devname);
void do_monitor(struct supertype *container);
void do_manager(struct supertype *container);
extern int sigterm;
extern volatile sig_atomic_t sigterm;

Check failure on line 84 in mdmon.h

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING:VOLATILE: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst

int read_dev_state(int fd);
bool is_container_member(struct mdstat_ent *mdstat, char *container);
Expand Down