mdadm: check logical block size compatibility #227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the kernel started supporting the logical block size feature, it modified the array metadata, which may lead to compatibility issues. Therefore, a compatibility warning needs to be added. Signed-off-by: Wu Guanghao <[email protected]>
mtkaczyk
reviewed
Jan 12, 2026
| if (sysfs_attribute_available(info, NULL, "logical_block_size") && | ||
| sysfs_get_str(info, NULL, "metadata_version", buf, sizeof(buf)) > 0 && | ||
| !memcmp(buf, "1.", 2)) { | ||
| pr_info("Arrays created by newer kernels have the logical block size feature enabled " |
Member
There was a problem hiding this comment.
Warning here is not really valuable. I don't think people will remember, the array creation and kernel downgrade are usually not corelated,
If you see a risk, and risk is big enough to protect user then you should verify metadata and block mdadm from assembling such array with wrong kernel.
Member
There was a problem hiding this comment.
I'm of course open for discussion, please share you point of view.
For sure there are reasons you implemented it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the kernel started supporting the logical block size feature, it modified the array metadata, which may lead to compatibility issues. Therefore, a compatibility warning needs to be added.
Links: https://lore.kernel.org/linux-raid/[email protected]/T/#t
Signed-off-by: Wu Guanghao [email protected]