mdadm: load md_mod first #228
Open
+40
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load md_mod first before setting module parameter legacy_async_del_gendisk Everything works well if md_mod is built in kernel. If not, create and assemble will fail. Fixes: d354d31 ("mdadm: Create array with sync del gendisk mode") Signed-off-by: Xiao Ni <[email protected]>
mtkaczyk
reviewed
Jan 7, 2026
| if (system("modprobe md_mod") == 0) | ||
| fd = open(new_array_file, O_WRONLY); | ||
| } | ||
| if (fd >= 0) { |
Member
There was a problem hiding this comment.
if (!is_fd_valid(fd)){
pr_err("Fail to open %s\n", new_array_file);
return 0;
}
n = write(fd, devnm, strlen(devnm));
close(fd);
if (n != (int)strlen(devnm)) {
Looks like simpler.
Collaborator
Author
There was a problem hiding this comment.
if (!is_fd_valid(fd)){ pr_err("Fail to open %s\n", new_array_file); return 0; } n = write(fd, devnm, strlen(devnm)); close(fd); if (n != (int)strlen(devnm)) {Looks like simpler.
Hi Mariusz
The codes mentioned above don't have relationship with this problem, right? You mean this part can be improved in this way, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load md_mod first before setting module parameter legacy_async_del_gendisk Everything works well if md_mod is built in kernel. If not, create and assemble will fail.