Skip to content

feat: separate bulk-edit trigger from column sort#788

Open
mylaser215 wants to merge 1 commit into
mdelobelle:masterfrom
mylaser215:feat/bulk-edit-ui-improvements
Open

feat: separate bulk-edit trigger from column sort#788
mylaser215 wants to merge 1 commit into
mdelobelle:masterfrom
mylaser215:feat/bulk-edit-ui-improvements

Conversation

@mylaser215

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #787. Improves the bulk edit UX in MDM fileclass table views:

  • Separate bulk-edit from sort: Column header click now only sorts. A dedicated pencil icon button triggers bulk edit for each column, preventing accidental edits when sorting.
  • Checkbox toggle isolation: The checkbox toggler (list-todo icon) uses stopPropagation() to avoid triggering column sort when toggling row selection.
  • Pencil buttons auto-show/hide: Bulk-apply pencil buttons appear only when checkboxes are visible, keeping the UI clean.
  • Async safety for bulk edit confirm: MultiTargetModificationConfirmModal confirm handler now uses async/await to process files sequentially, preventing potential race conditions when editing multiple files.
  • CSS cleanup: Unified icon sizes (22px), added hover styles for bulk-apply buttons, added cleanTable cleanup for .bulk-apply-btn elements.

Files Changed

  • src/fileClass/views/tableViewComponents/fileClassDataviewTable.ts — UI logic refactor
  • src/assets/css/fileclass.scss — Styles for .bulk-apply-btn and .checkbox-toggler
  • src/fields/base/BaseModal.ts — async/await in confirm handler

Test plan

  • Open a fileclass table view with multiple fields
  • Click column headers → should only sort (no bulk edit modal)
  • Toggle checkboxes → pencil icons appear on each column
  • Click pencil icon → bulk edit modal opens for that column
  • Hide checkboxes → pencil icons disappear
  • Bulk edit multiple files → verify no race conditions (fields not cleared)

🤖 Generated with Claude Code

- Add per-column pencil button for bulk edit (replaces column header click)
- Checkbox toggle now only controls row selection, with stopPropagation
- Pencil buttons auto-show/hide with checkbox visibility
- Add async/await to MultiTargetModificationConfirmModal for sequential
  file processing safety
- Unify icon sizes to 22px, add hover styles for bulk-apply button
- Clean up bulk-apply buttons in cleanTable

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants