Add supportArraysForHtml transformer #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
force-pushed
the
html-array-exploration
branch
from
55a540b to
52ea6a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran this on this benchmark and got around a 60% performance increase on Chrome, and a 50% increase on Firefox.
Explanation of the transformer can be found at the top of
supportArraysForHtml.ts.More work can (and probably should) be done to increase the number of places that this transformation applies (doesn't apply to SVG or custom nodes for instance).
I have not yet tested this extensively on a codebase.
The idea for this optimization was pitched to me by @evancz a while ago.