Add optimization that fuses together map functions#116
Draft
jfmengels wants to merge 48 commits intomdgriffith:masterfrom
Draft
Add optimization that fuses together map functions#116jfmengels wants to merge 48 commits intomdgriffith:masterfrom
jfmengels wants to merge 48 commits intomdgriffith:masterfrom
Conversation
|
Very nice to see the performance benchmarks, thanks for this! 💪🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this optimization is to avoid having consecutive
mapfunctions, and instead grouping them using composition. So instead of:we'd in practice end up with
Some benchmarks can be found in this folder: https://github.com/jfmengels/elm-benchmarks/tree/master/src/FusionExploration
It seems to be worthwhile to have, as shown for instance by this benchmark:
Function composition like this has its own performance drawbacks compared to lambdas, but that's where #73 can come in and save the day.
I made this branch a long time ago, and I don't remember where it's at, or why I didn't end up creating a PR for it. So I'll just make a draft and then other people can see it or take inspiration from it. Ping me to put eyes on it again when some time gets unblocked for this project.