Firefox 146 supports compressed ECC key point format #28497
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1158,6 +1158,44 @@ | |
| "deprecated": false | ||
| } | ||
| }, | ||
| "compressed_elliptic_curve_points": { | ||
| "__compat": { | ||
| "description": "ECDSA or ECDH key data can contain compressed elliptic curve points.", | ||
| "spec_url": "https://w3c.github.io/webcrypto/#ecdsa-operations-import-key", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "≤80" | ||
|
||
| }, | ||
| "chrome_android": "mirror", | ||
| "deno": { | ||
| "version_added": false | ||
|
||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "146" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "nodejs": { | ||
| "version_added": false | ||
| }, | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
hamishwillee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": "mirror", | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
hamishwillee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "deprecated": false | ||
| } | ||
| } | ||
| }, | ||
| "ed25519": { | ||
| "__compat": { | ||
| "description": "`Ed25519` algorithm", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to respond to the spec question below, but I'm -0 on adding this subfeature. Speaking as a consumer of BCD (i.e., for web-features), this makes the data even harder to work with and, as written, is not something we can use to generate a status in web-features.
In a better world, this data would be represented as
api.SubtleCrypto.importKey.ecdsa.compressed_elliptic_curve_pointsandapi.SubtleCrypto.importKey.ecdh.compressed_elliptic_curve_points. But we don't have keys forecdsaandecdh, we just have notes inimportKeyfeature. This makes the problem worse by creating a named subfeature to notes of the parent feature, not the parent feature itself.I won't block on merging this—I do not have the time this month to do a rounds of follow up and re-review—but I think the addition of this subfeature makes the problem described in #27669 worse and I would like you to reconsider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @ddbeck I don't want to make your life harder, so I have made the subkeys "as best I can". See notes in https://github.com/mdn/browser-compat-data/pull/28497/files#r2596825715
There is no point injecting crap. If you or @caugner don't have time to review then it will just have to wait until whenever. At least the information won't be lost.