-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Misc LargestContentfulPaint updates #28658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
api/LargestContentfulPaint.json
Outdated
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "140" | ||
| "version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collector detected support and it seems it is exposed. The null behavior seems to be per spec also? Maybe we should mark it as partial? (this is always weird for feature detection but oh well).
| "version_added": false | |
| "version_added": "140", | |
| "partial_implementation": true, | |
| "notes": "This property is exposed, but always returns `null`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is effectively allowed per spec not to support this I agree, so it is an optional feature. But this is where it's even more important for MDN to document this IMHO.
Also I agree the fact it's there (but always null) could be interpreted as having "partial support". But to me, since it's always null, it's equivalent to "no support" rather than partial.
WDYT @canova from an Firefox side? And @smfr from a Safari size? Do you think it's fair to say you have not implemented presentationTime at this time for LCP? Note Interop and Baseline definitions do not include this key, and I'm keen to keep that this way, since these are optional, so you would still be marked as supporting LCP in those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's go with partial support for now, to unblock this, since there are other updates in this PR I'd like to have sooner rather than later and partial is certainly better than the current reading of them having full support. But curious to hear @canova and @smfr's opinion and can follow up with another PR if necessary.
api/LargestContentfulPaint.json
Outdated
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": "26.2" | ||
| "version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "version_added": false | |
| "version_added": "26.2", | |
| "partial_implementation": true, | |
| "notes": "This property is exposed, but always returns `null`." |
Co-authored-by: Florian Scholz <[email protected]>
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tunetheweb, let's go with partial for now.
Summary
Correct erroneous LargestContentfulPaint data I spotted:
presentationTimepaintTimeandpresentationTimebut behind a flag (unflagging in Chrome 145!)Test results and supporting details
Safari does support cross-origin lcp render time but not

presentationTime(tested on https://www.tunetheweb.com/experiments/lcp-cross-origin/)Firefox gives null for
presentationTime:Chrome 134 supports
paintTimeandpresentationTimewhen experimental web platform features are turned on:Related issues