Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStream reader - releasing lock throws pending read #18241

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

hamishwillee
Copy link
Collaborator

This does two main things:

  1. Fixes up FF102 release note to point to the guide on using readable byte streams
  2. Fixes up the readable stream reader releaseLock() and read() interfaces to make it clear that if releaseLock is called and there is a pending read then it is the read() promise that is rejected (formerly releaseLock() would throw.

This is due to a spec change in whatwg/streams#1168.

I also removed a bunch of cases where we referred to "resolves" when we mean fulfills.

@hamishwillee hamishwillee requested review from a team as code owners July 12, 2022 01:13
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team July 12, 2022 01:13
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

@sideshowbarker sideshowbarker merged commit 1ad9ff9 into mdn:main Jul 12, 2022
@hamishwillee hamishwillee deleted the ff102_readable_byte_stream_tidy branch July 15, 2022 02:09
@hamishwillee
Copy link
Collaborator Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants