-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadableStream reader - releasing lock throws pending read #18241
Merged
sideshowbarker
merged 4 commits into
mdn:main
from
hamishwillee:ff102_readable_byte_stream_tidy
Jul 12, 2022
Merged
ReadableStream reader - releasing lock throws pending read #18241
sideshowbarker
merged 4 commits into
mdn:main
from
hamishwillee:ff102_readable_byte_stream_tidy
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sideshowbarker
approved these changes
Jul 12, 2022
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two main things:
releaseLock()
andread()
interfaces to make it clear that if releaseLock is called and there is a pending read then it is the read() promise that is rejected (formerlyreleaseLock()
would throw.This is due to a spec change in whatwg/streams#1168.
I also removed a bunch of cases where we referred to "resolves" when we mean fulfills.