Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add sandbox attrs to live samples that call open() #38271

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Feb 21, 2025

Changes:

  • Add 'allow-popups' to several live samples
  • Minor tidy of code in some live samples

Fixes:

  • External links in See also

Motivation

Making live samples work again.

Related issues and pull requests

Fixes #34350

PRs:

@bsmth bsmth requested a review from a team as a code owner February 21, 2025 15:10
@bsmth bsmth requested review from sideshowbarker and removed request for a team February 21, 2025 15:10
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Feb 21, 2025
Copy link
Contributor

Preview URLs

Flaws (2)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Media_Capture_and_Streams_API/Taking_still_photos
Title: Taking still photos with getUserMedia()
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/aspect_ratio is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/aspect_ratio which is a redirect

@sideshowbarker sideshowbarker merged commit 9b52765 into mdn:main Feb 21, 2025
7 checks passed
@bsmth bsmth deleted the window_open branch February 24, 2025 09:26
@bsmth
Copy link
Member Author

bsmth commented Feb 24, 2025

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live examples using window.open are broken
2 participants