Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicKeyCredential: Remove NotAllowed exceptions and add security exceptions #38617

Merged

Conversation

hamishwillee
Copy link
Collaborator

The WGC clarified that you don't need permissions to call PublicKeyCredential.isUserVerifyingPlatformAuthenticatorAvailable() or PublicKeyCredential.getClientCapabilities() in w3c/webauthn#2251 (comment). This removes the corresponding NotAllowed exception.

The PR also adds the SecurityException for all methods in this API, because a secure context is requried.

This fell out of work done in #37516

@hamishwillee hamishwillee requested a review from a team as a code owner March 14, 2025 00:23
@hamishwillee hamishwillee requested review from wbamberg and removed request for a team March 14, 2025 00:23
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Mar 14, 2025
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for wbamberg March 14, 2025 00:23
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @hamishwillee.

@chrisdavidmills chrisdavidmills merged commit dd49e9f into mdn:main Mar 17, 2025
7 checks passed
bramus pushed a commit to bramus/mdn-content that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants