Skip to content

clip-path update #39165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2025
Merged

clip-path update #39165

merged 10 commits into from
Apr 19, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 16, 2025

moving the examples, which are the fully drawn owl, to a guide, and making the examples way more basic.,
committing this before the whole project is complete because this is turning into a huge project, and the rect() example in the drop down is broken.

will add the new guide and module in when the guide is complete.

part of openwebdocs/project#224 and #39151

@estelle estelle requested a review from a team as a code owner April 16, 2025 20:52
@estelle estelle requested review from chrisdavidmills and removed request for a team April 16, 2025 20:52
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Apr 16, 2025
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Preview URLs

Flaws (10)

URL: /en-US/docs/Web/CSS/clip-path
Title: clip-path
Flaw count: 10

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • and 2 more flaws omitted

(comment last updated: 2025-04-19 05:12:15)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle reviewed! Looking good, just a few suggestions for you to consider.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from chrisdavidmills April 17, 2025 17:29
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle LGTM, except for one minor text tweak suggestion ("exists" seemed like the wrong word there). Approving so as not to hold you up.

@estelle estelle merged commit c60addb into main Apr 19, 2025
12 checks passed
@estelle estelle deleted the estelle-patch-4 branch April 19, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants