Skip to content

chore(jsondata): add Handler_methods L10n key#44264

Closed
caugner wants to merge 1 commit into
mdn:mainfrom
caugner:l10n-common-handler-methods
Closed

chore(jsondata): add Handler_methods L10n key#44264
caugner wants to merge 1 commit into
mdn:mainfrom
caugner:l10n-common-handler-methods

Conversation

@caugner

@caugner caugner commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Add a Handler_methods entry to L10n-Common.json with translations for de, en-US, es, fr, ja, ko, ru, zh-CN.

Motivation

Used by rari's JS reference sidebar for a new "Handler methods" group on Proxy/* pages (see mdn/rari#728). Without this key, l10n_json_data returns an error and the affected sidebar build fails.

Additional details

Translations were sourced from established usage in the existing Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/** pages of translated-content and translated-content-de. Each mirrors the locale's existing "X methods" pattern (e.g. Instance_methods → "Méthodes d'instance" ⇒ "Méthodes du gestionnaire"; German "Handler-Funktionen" ⇒ "Handler-Methoden").

pt-BR and zh-TW are omitted because the source content is not translated in those locales; they will fall back to en-US.

Related issues and pull requests

Related to mdn/rari#728.

Used by rari's JS reference sidebar for a new "Handler methods" group
on `Proxy/*` pages. Translations sourced from existing `Proxy/Proxy/*`
content in `translated-content` and `translated-content-de`.
@github-actions github-actions Bot added the size/s [PR only] 6-50 LoC changed label May 26, 2026
@caugner
caugner marked this pull request as ready for review May 26, 2026 16:57
@caugner
caugner requested a review from a team as a code owner May 26, 2026 16:57
@caugner
caugner requested review from dipikabh and removed request for a team May 26, 2026 16:57
"ja": "ハンドラーメソッド",
"ko": "처리기 메서드",
"ru": "Методы обработчика",
"zh-CN": "处理器方法"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/zh-content

@yin1999 yin1999 May 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still add the Traditional Chinese translation (we won't need to add it again in the future).

Suggested change
"zh-CN": "处理器方法"
"zh-CN": "处理器方法",
"zh-TW": "處理器方法"

"Handler_methods": {
"de": "Handler-Methoden",
"en-US": "Handler methods",
"es": "Métodos del manejador",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/es-content

"de": "Handler-Methoden",
"en-US": "Handler methods",
"es": "Métodos del manejador",
"fr": "Méthodes du gestionnaire",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/fr-content

"en-US": "Handler methods",
"es": "Métodos del manejador",
"fr": "Méthodes du gestionnaire",
"ja": "ハンドラーメソッド",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/ja-content

"es": "Métodos del manejador",
"fr": "Méthodes du gestionnaire",
"ja": "ハンドラーメソッド",
"ko": "처리기 메서드",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/ko-content

"fr": "Méthodes du gestionnaire",
"ja": "ハンドラーメソッド",
"ko": "처리기 메서드",
"ru": "Методы обработчика",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/ru-content

"ja": "ハンドラーメソッド",
"ko": "처리기 메서드",
"ru": "Методы обработчика",
"zh-CN": "处理器方法"

@yin1999 yin1999 May 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still add the Traditional Chinese translation (we won't need to add it again in the future).

Suggested change
"zh-CN": "处理器方法"
"zh-CN": "处理器方法",
"zh-TW": "處理器方法"

@JuanVqz JuanVqz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ES team

@caugner
caugner marked this pull request as draft May 27, 2026 05:58

@tristantheb tristantheb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner

caugner commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

Apologies everyone, it seems that this new L10n key isn't needed after all.

I should have waited before pinging everyone.

@caugner caugner closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants