Page updates: column-rule-*#44755
Conversation
Preview URLs (6 pages)
Flaws (25)Note! 1 document with no flaws that don't need to be listed. 🎉 Found an unexpected or unresolvable flaw? Please report it here. URL:
URL:
URL:
URL:
URL:
External URLs (3)URL:
(comment last updated: 2026-07-18 22:56:40) |
| The **`column-rule-color`** [CSS](/en-US/docs/Web/CSS) property sets the color of the line drawn between columns in a multi-column layout. | ||
| The **`column-rule-color`** [CSS](/en-US/docs/Web/CSS) property defines the colors of the lines drawn between columns in multi-column grid, flex, and multi-col layouts. | ||
|
|
||
| {{InteractiveExample("CSS Demo: column-rule-color")}} |
There was a problem hiding this comment.
FYI the example is too wide for the page. That makes it hard to be precisely sure of the behaviour.
There was a problem hiding this comment.
made it narrower, but i can't overflow because that property breaks the interactive example
|
|
||
| The value is a comma-separated list of components, which can include `<line-color>`, `<repeated-line-color>`, and `<auto-repeat-line-color>` types. | ||
|
|
||
| The `column-rule-color`, along with the {{cssxref("column-rule-width")}} and {{cssxref("column-rule-style")}} properties, can be set using the {{cssxref("column-rule")}} shorthand. The `column-rule-color`, along with the {{cssxref("row-rule-color")}} property, can also be set using the {{cssxref("rule-color")}} shorthand. |
There was a problem hiding this comment.
FYI {{cssxref("rule-color")}} is a redlink
| @@ -46,16 +45,17 @@ column-rule-color: #8888ff; | |||
|
|
|||
| ```css interactive-example | |||
| #example-element { | |||
There was a problem hiding this comment.
Line duplicated below
| #example-element { |
There was a problem hiding this comment.
this is what made the example fail.
|
|
||
| #### Result | ||
|
|
||
| {{EmbedLiveSample("Multiple", "", "180")}} |
There was a problem hiding this comment.
FWIW the use of multiple here seems to work. The https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Live_samples doesn't state whether the identifier is case sensitive or not.
There was a problem hiding this comment.
They are not case sensitive. EmbedLiveSample first parameter is very forgiving actually
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)) thin; |
There was a problem hiding this comment.
Is this line valid? Might need a comma before thin if the next example is correct.
| column-rule-color: blue, repeat(auto, yellow), red; | ||
| ``` | ||
|
|
||
| In this case, the first column-rule will be blue, the last will be red, and all others will be yellow. It doesn't matter if the container has; the first will always be blue and, as long as there are at least two column-rules, the last will always be red. All the other rules will be yellow, which means if there are only 2 or 3 columns, there will be no yellow lines. |
There was a problem hiding this comment.
What does this mean?
It doesn't matter if the container has;
There was a problem hiding this comment.
As long as there are at least two column-rules, the first will always be blue and the last will always be red.
| --base: 0.5vw; | ||
| --secondary: 1vw; |
There was a problem hiding this comment.
Claude says these are unused elsewhre in the example (copy paste)
hamishwillee
left a comment
There was a problem hiding this comment.
@estelle Do you have Claude? Running a prompt such as "Review this for spelling and grammar issues" caught quite a few typos.
Still going on my own review ("does it make sense to me as a reader")
|
|
||
| We start by defining the list as a grid container, creating columns with the {{cssxref("grid-template-columns")}} property. We include a {{cssxref("gap")}} of `7px` to provide enough room between the columns to fit our `3px` dashed rule, and remove the bullets with {{cssxref("list-style-type")}} set to `none`. | ||
|
|
||
| Then, to demonstrate how values can become complicated and the utility of the `repeat()` function, we declare two custom properties, which we use in three {{cssxref("color-mix()")}} color function declarations to create blue, red, and yellow colors. The yellow `color-mix()` color is within a `repeat()` function, set to repeat 3 times. |
There was a problem hiding this comment.
FWIW I think using the color mix here distracts from the example - its just extra noise.
There was a problem hiding this comment.
it's actually intentional to show that it helps make ridiculous code less ridiculous
| The **`column-rule-style`** [CSS](/en-US/docs/Web/CSS) property sets the style of the line drawn between columns in a multi-column layout. | ||
| The **`column-rule-style`** [CSS](/en-US/docs/Web/CSS) property defines the line style of the lines drawn between columns in multi-column grid, flex, and multi-col layouts. | ||
|
|
||
| {{InteractiveExample("CSS Demo: column-rule-style")}} |
There was a problem hiding this comment.
Doesnt work at all because only one column is displayed.
| --- | ||
|
|
||
| The **`column-rule-style`** [CSS](/en-US/docs/Web/CSS) property sets the style of the line drawn between columns in a multi-column layout. | ||
| The **`column-rule-style`** [CSS](/en-US/docs/Web/CSS) property defines the line style of the lines drawn between columns in multi-column grid, flex, and multi-col layouts. |
There was a problem hiding this comment.
I "fixed" other example of multi-col layouts to multi-column layouts. If this is reasonable, also needs to be fixed everywhere.
There was a problem hiding this comment.
it think it needs to be multi-col. it was multi-col, and it reads "multi-column grid" in the same sentence, so needs to be differentiated
| The **`column-rule-width`** [CSS](/en-US/docs/Web/CSS) property sets the width of the line drawn between columns in a multi-column layout. | ||
| The **`column-rule-width`** [CSS](/en-US/docs/Web/CSS) property defines the widths of the lines drawn between columns in multi-column grid, flex, and multi-col layouts. | ||
|
|
||
| {{InteractiveExample("CSS Demo: column-rule-width")}} |
There was a problem hiding this comment.
Example too narrow for page.
There was a problem hiding this comment.
yeah, but i have to keep it b/c we need to show repeat. and adding overflow breaks the examples.
| @@ -7,43 +7,52 @@ browser-compat: css.properties.column-rule | |||
| sidebar: cssref | |||
There was a problem hiding this comment.
Page looks good/consistent. FWIW a few redlinks, but I am sure you know about those.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
| 1rem, | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| min(calc(var(--base) - 3px), 10px), | ||
| abs(calc(var(--secondary) - 30px)), | ||
| thin; |
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
| 1rem, | |
| min(calc(var(--base) - 3px), 10px), | |
| abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), | |
| abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), | |
| abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), | |
| abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), | |
| abs(calc(var(--secondary) - 30px)), | |
| thin; | |
| 1rem, min(calc(var(--base) - 3px), 10px), abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), abs(calc(var(--secondary) - 30px)), | |
| min(calc(var(--base) - 3px), 10px), abs(calc(var(--secondary) - 30px)), thin; |
This PR includes a complete revision of four existing pages:
The CSS gaps module page is already live.
That previous PR included the task of "Update pages to correct module (gap has been moved from mod to mod)"
This starts the section of openwebdocs/project#238 of "Update pages to new definition"