Fix inline styles in Web/API - x #5517

hamishwillee · 2021-05-31T23:02:26Z

Part of fixing #5438

Window and XML cases.

hamishwillee · 2021-05-31T23:03:21Z

files/en-us/web/api/xrinputsource/gripspace/index.html

-
-<p class="cleared">As shown in the diagram above, the coordinate system is oriented as
-  follows:</p>
+<p><strong>The coordinate system for the left hand's grip space.</strong></p>


FYI, this just renders figure captions as bold heading followed by image

files/en-us/web/api/windoworworkerglobalscope/setinterval/index.html

github-actions · 2021-05-31T23:04:46Z

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window/screenX
Title: Window.screenX
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/Window/setImmediate
Title: Window.setImmediate()
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/Window/screenLeft
Title: Window.screenLeft
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/Window/screenTop
Title: Window.screenTop
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/Window/screenY
Title: Window.screenY
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/Window/popstate_event
Title: Window: popstate event
on GitHub
Flaw count: 9

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist
- and 2 more flaws omitted
broken_links:
- Anchor not lowercase
- Anchor not lowercase

URL: /en-US/docs/Web/API/Window/open/Privileged_features
Title: Privileged features
on GitHub
Flaw count: 4

broken_links:
- Is currently http:// but can become https://
- Is currently http:// but can become https://
- Is currently http:// but can become https://
- Is currently http:// but can become https://

URL: /en-US/docs/Web/API/Window/scrollX
Title: Window.scrollX
on GitHub
Flaw count: 5

macros:
- /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
- /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
- /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
- /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
- /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/XRTargetRayMode
Title: XRTargetRayMode
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.XRTargetRayMode

URL: /en-US/docs/Web/API/WindowOrWorkerGlobalScope/setInterval
Title: WindowOrWorkerGlobalScope.setInterval()
on GitHub
Flaw count: 2

broken_links:
- Can't resolve /files/3997/typewriter.html
- Can't resolve /files/3995/minidaemon_example.html

URL: /en-US/docs/Web/API/XRInputSource
Title: XRInputSource
on GitHub
Flaw count: 3

macros:
- /en-US/docs/Web/API/XRInputSource/gamepad does not exist
broken_links:
- Can't resolve /en-US/docs/Web/WebXR%20Device%20API/Gamepads
bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest
Title: Using XMLHttpRequest
on GitHub
Flaw count: 13

macros:
- /en-US/docs/Web/API/XMLHttpRequest/FormData redirects to /en-US/docs/Web/API/FormData
- /en-US/docs/Web/API/XMLHttpRequest/sendAsBinary does not exist
- /en-US/docs/Web/API/XMLHttpRequest/FormData redirects to /en-US/docs/Web/API/FormData
broken_links:
- Can't resolve /en-US/docs/DOM/XMLHttpRequest/Synchronous_and_Asynchronous_Requests
- Can't resolve /en-US/docs/DOM/XMLHttpRequest/Sending_and_Receiving_Binary_Data
- Can't resolve /en-US/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects
- Anchor not lowercase
- Anchor not lowercase
- and 5 more flaws omitted

URL: /en-US/docs/Web/API/XMLDocument/load
Title: XMLDocument.load()
on GitHub
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/XML_in_Mozilla

External URLs

URL: /en-US/docs/Web/API/Window/screenX
Title: Window.screenX
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/setImmediate
Title: Window.setImmediate()
on GitHub

https://code.google.com/p/chromium/issues/detail?id=146172 (1 time) (Note! This may be a new URL 👀)
https://www.nczonline.net/blog/2009/08/11/timed-array-processing-in-javascript/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/Window/screenLeft
Title: Window.screenLeft
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/screenTop
Title: Window.screenTop
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/screenY
Title: Window.screenY
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/popstate_event
Title: Window: popstate event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/open/Privileged_features
Title: Privileged features
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/scrollX
Title: Window.scrollX
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRTargetRayMode
Title: XRTargetRayMode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WindowOrWorkerGlobalScope/setInterval
Title: WindowOrWorkerGlobalScope.setInterval()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRInputSource
Title: XRInputSource
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRInputSource/gripSpace
Title: XRInputSource.gripSpace
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest
Title: Using XMLHttpRequest
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XMLDocument/load
Title: XMLDocument.load()
on GitHub

https://www.w3.org/TR/2003/WD-DOM-Level-3-LS-20030619/load-save.html (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/XDomainRequest/timeout
Title: XDomainRequest.timeout
on GitHub

No new external URLs

(this comment was updated 2021-06-01 07:04:34.080285)

hamishwillee · 2021-05-31T23:21:50Z

files/en-us/web/api/window/screenleft/index.html

-    </tr>
-  </tbody>
-</table>
+<p>{{Specifications}}</p>


Note, fixed a few cases of style in spec table just by adding this macro (I tested it works).

wbamberg

Looks great but I suggest removing a couple of old broken add-ons links. Thanks @hamishwillee !

files/en-us/web/api/windoworworkerglobalscope/setinterval/index.html

Done

wbamberg · 2021-06-01T03:51:49Z

I didn't see the links removed, are you sure this was done?
https://github.com/mdn/content/pull/5517/files#diff-457e6ef5db81b8c470346dec79428f943d82d1af557b3ef3d2050eea747d19f6R487

hamishwillee · 2021-06-01T07:03:40Z

Apologies. Made change but must have forgotten to push it. Done now.

wbamberg · 2021-06-01T14:14:13Z

👍 thank you @hamishwillee !

hamishwillee added 7 commits June 1, 2021 08:38

XDomainRequest.timeout - fix inline styles

a8674a9

XMLDocument.load() fix inline styles

f7abf32

Using XMLHttpRequest: fix inline styles

bec1405

XRInputSource.gripSpace fix inline styles

2a86105

XRInputSource - fix inline styles

03d156d

XRTargetRayMode - fix inline styles

ca23030

windoworworkerglobalscope/setinterval - fix inline styles

b53d508

hamishwillee commented May 31, 2021

View reviewed changes

files/en-us/web/api/windoworworkerglobalscope/setinterval/index.html Show resolved Hide resolved

hamishwillee added 7 commits June 1, 2021 09:07

Window.setImmediate - fix inline styles

57ffece

Window.scrollX - fix inline styles

8b0d090

Window.screenY - fix inline styles

fa680b6

Window.screenX - fix inline styles

c671e30

Window popstate event - fix inline styles

7b4e479

Window.screenxxxx - fix style by adding specifications macro

cee3ad2

Window.open privil. features - fix inline styles

73d47c1

hamishwillee commented May 31, 2021

View reviewed changes

hamishwillee marked this pull request as ready for review May 31, 2021 23:22

hamishwillee requested a review from a team as a code owner May 31, 2021 23:22

hamishwillee requested review from jpmedley and wbamberg and removed request for a team and jpmedley May 31, 2021 23:22

wbamberg previously requested changes May 31, 2021

View reviewed changes

files/en-us/web/api/windoworworkerglobalscope/setinterval/index.html Outdated Show resolved Hide resolved

Remove Add-ons broken links. Fix anchor in heading

088cad0

wbamberg approved these changes Jun 1, 2021

View reviewed changes

wbamberg merged commit de26fb3 into mdn:main Jun 1, 2021

github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inline styles in Web/API - x #5517

Fix inline styles in Web/API - x #5517

hamishwillee commented May 31, 2021 •

edited

Loading

hamishwillee May 31, 2021

github-actions bot commented May 31, 2021 •

edited

Loading

hamishwillee May 31, 2021

wbamberg left a comment

wbamberg commented Jun 1, 2021

hamishwillee commented Jun 1, 2021

wbamberg commented Jun 1, 2021

Fix inline styles in Web/API - x #5517

Fix inline styles in Web/API - x #5517

Conversation

hamishwillee commented May 31, 2021 • edited Loading

hamishwillee May 31, 2021

Choose a reason for hiding this comment

github-actions bot commented May 31, 2021 • edited Loading

Preview URLs

Flaws

External URLs

hamishwillee May 31, 2021

Choose a reason for hiding this comment

wbamberg left a comment

Choose a reason for hiding this comment

wbamberg commented Jun 1, 2021

hamishwillee commented Jun 1, 2021

wbamberg commented Jun 1, 2021

hamishwillee commented May 31, 2021 •

edited

Loading

github-actions bot commented May 31, 2021 •

edited

Loading