Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove style attributes from Web RTC pages #5724

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Remove style attributes from Web RTC pages #5724

merged 1 commit into from
Jun 7, 2021

Conversation

teoli2003
Copy link
Contributor

This is part of #5438.

It removes the style attributes in web rtc pages.

It was all mostly styles:

  • most were style in spec tables (that will go away anyway)
  • a few list in list styling (I changed it to an ul that works well in this case)
  • a few alignment in tables (not needed)

@teoli2003 teoli2003 requested a review from a team as a code owner June 6, 2021 07:49
@teoli2003 teoli2003 requested review from sideshowbarker and removed request for a team June 6, 2021 07:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2021

Preview URLs

Flaws

Note! 15 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCRtpTransceiverDirection
Title: RTCRtpTransceiverDirection
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCRtpParameters/encodings does not exist
    • /en-US/docs/Web/API/RTCRtpEncodingParameters/active does not exist

URL: /en-US/docs/Web/API/RTCPeerConnection/getIdentityAssertion
Title: RTCPeerConnection.getIdentityAssertion()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/API/RTCPeerConnection/getSenders
Title: RTCPeerConnection.getSenders()
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC_API

URL: /en-US/docs/Web/API/RTCPeerConnection/remoteDescription
Title: RTCPeerConnection.remoteDescription
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

URL: /en-US/docs/Web/API/RTCPeerConnection/setIdentityProvider
Title: RTCPeerConnection.setIdentityProvider()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/API/RTCPeerConnection/iceConnectionState
Title: RTCPeerConnection.iceConnectionState
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

URL: /en-US/docs/Web/API/RTCPeerConnection/removeTrack
Title: RTCPeerConnection.removeTrack()
on GitHub
Flaw count: 1

  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/API/RTCPeerConnection/iceGatheringState
Title: RTCPeerConnection.iceGatheringState
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

URL: /en-US/docs/Web/API/RTCPeerConnection/getReceivers
Title: RTCPeerConnection.getReceivers()
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC_API

URL: /en-US/docs/Web/API/RTCSessionDescription/toJSON
Title: RTCSessionDescription.toJSON()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/API/RTCSessionDescription/type
Title: RTCSessionDescription.type
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

URL: /en-US/docs/Web/API/RTCSessionDescription/sdp
Title: RTCSessionDescription.sdp
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

URL: /en-US/docs/Web/API/RTCSessionDescription/RTCSessionDescription
Title: RTCSessionDescription()
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC_API

URL: /en-US/docs/Web/API/RTCRtpReceiver/getStats
Title: RTCRtpReceiver.getStats()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Node/innerText redirects to /en-US/docs/Web/API/HTMLElement/innerText

URL: /en-US/docs/Web/API/RTCRtpSender/getStats
Title: RTCRtpSender.getStats()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Node/innerText redirects to /en-US/docs/Web/API/HTMLElement/innerText
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC_API

URL: /en-US/docs/Web/API/WebRTC_Statistics_API
Title: WebRTC Statistics API
on GitHub
Flaw count: 36

  • macros:
    • /en-US/docs/Web/API/RTCCertificateStats does not exist
    • /en-US/docs/Web/API/RTCCodecStats does not exist
    • /en-US/docs/Web/API/RTCRtpContributingSourceStats does not exist
    • /en-US/docs/Web/API/RTCDataChannelStats does not exist
    • /en-US/docs/Web/API/RTCIceServerStats does not exist
    • and 30 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: api.RTCStatsType

External URLs

URL: /en-US/docs/Web/API/RTCRtpTransceiverDirection
Title: RTCRtpTransceiverDirection
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Taking_still_photos
Title: Taking still photos with WebRTC
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Answer_a_call
Title: Answering a Call
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Creating_a_call
Title: Creating a Call
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Get_microphone_permission
Title: Getting browser microphone permission
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Connectivity
Title: WebRTC connectivity
on GitHub

URL: /en-US/docs/Web/API/WebRTC_API/Protocols
Title: Introduction to WebRTC protocols
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/getIdentityAssertion
Title: RTCPeerConnection.getIdentityAssertion()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/peerIdentity
Title: RTCPeerConnection.peerIdentity
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/getSenders
Title: RTCPeerConnection.getSenders()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/remoteDescription
Title: RTCPeerConnection.remoteDescription
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/setIdentityProvider
Title: RTCPeerConnection.setIdentityProvider()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/iceConnectionState
Title: RTCPeerConnection.iceConnectionState
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/removeTrack
Title: RTCPeerConnection.removeTrack()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/iceGatheringState
Title: RTCPeerConnection.iceGatheringState
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/getReceivers
Title: RTCPeerConnection.getReceivers()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnectionIceEvent/candidate
Title: RTCPeerConnectionIceEvent.candidate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/toJSON
Title: RTCSessionDescription.toJSON()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/type
Title: RTCSessionDescription.type
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/sdp
Title: RTCSessionDescription.sdp
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/RTCSessionDescription
Title: RTCSessionDescription()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCRtpReceiver/getStats
Title: RTCRtpReceiver.getStats()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCRtpSender/getStats
Title: RTCRtpSender.getStats()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannelEvent/RTCDataChannelEvent
Title: RTCDataChannelEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/ordered
Title: RTCDataChannel.ordered
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/onclose
Title: RTCDataChannel.onclose
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/label
Title: RTCDataChannel.label
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/bufferedAmountLowThreshold
Title: RTCDataChannel.bufferedAmountLowThreshold
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDataChannel/bufferedAmount
Title: RTCDataChannel.bufferedAmount
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_Statistics_API
Title: WebRTC Statistics API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDTMFToneChangeEvent/tone
Title: RTCDTMFToneChangeEvent.tone
on GitHub

No new external URLs

hamishwillee
hamishwillee approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing of beauty :-). Thank you.

@hamishwillee hamishwillee merged commit da2f6f9 into mdn:main Jun 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @hamishwillee