Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles from Web/API docs #5729

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

Blakelist7
Copy link
Contributor

Part of fixing #5438

@Blakelist7 Blakelist7 requested a review from a team as a code owner June 6, 2021 11:27
@Blakelist7 Blakelist7 requested review from sideshowbarker and removed request for a team June 6, 2021 11:27
@github-actions

This comment has been minimized.

@hamishwillee
Copy link
Collaborator

Thanks very much! Good job. I've added a few review comments. Probably more than needed but I figure we will try be consistent :-)

@sideshowbarker
Copy link
Member

Thanks very much! Good job. I've added a few review comments. Probably more than needed but I figure we will try be consistent :-)

@hamishwillee Those comments don’t seem to be showing up here yet?

@hamishwillee
Copy link
Collaborator

Thanks @sideshowbarker - made the review non-pending.

@Blakelist7 Blakelist7 requested a review from hamishwillee June 7, 2021 08:43
@Blakelist7 Blakelist7 requested a review from hamishwillee June 7, 2021 08:50
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much for helping with this huge (and fiddly) job.

@hamishwillee hamishwillee merged commit f25f9e8 into mdn:main Jun 7, 2021
@Blakelist7 Blakelist7 deleted the InlineStyles3 branch June 8, 2021 02:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants