Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID attributes in AudioParam page #8307

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Conversation

wbamberg
Copy link
Collaborator

This is part of #7899.

This removes the id attributes from https://developer.mozilla.org/en-US/docs/Web/API/AudioParam.

As @teoli2003 pointed out in #7899 (comment), there are lots of links to these, so I've chosen an approach which keeps the id values the same, so all those links will still work.

@wbamberg wbamberg requested a review from a team as a code owner August 26, 2021 00:49
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team August 26, 2021 00:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/AudioParam
Title: AudioParam
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/AudioParam
Title: AudioParam
on GitHub

No new external URLs

(this comment was updated 2021-08-26 03:38:46.332634)

wbamberg and others added 2 commits August 25, 2021 20:37
Co-authored-by: Michael[tm] Smith <[email protected]>
Co-authored-by: Michael[tm] Smith <[email protected]>
@wbamberg
Copy link
Collaborator Author

Thanks @sideshowbarker ! Good suggestions.

@sideshowbarker sideshowbarker merged commit 533245e into mdn:main Aug 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
@wbamberg wbamberg deleted the fix-audioparam branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants