Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'highlight:[]' and 'highlight[]' classes #8368

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Remove 'highlight:[]' and 'highlight[]' classes #8368

merged 4 commits into from
Aug 26, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Aug 26, 2021 •
edited
Loading

This is part of #8364 .

The highlight[...] and highlight:[...] classes are not supported in Markdown and the converter will not convert code blocks that contain them.

This PR removes them.

One risk with this is that the text refers explicitly to highlighted lines, which then wouldn't make any sense. I've done my best to check that this isn't happening. Also it's worth noting that highlight has never worked in Yari.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 176 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Worklet/addModule
Title: Worklet.addModule()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RequestCredentials does not exist
    • /en-US/docs/Web/CSS/paint() redirects to /en-US/docs/Web/CSS/image/paint()

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation
Title: CanvasRenderingContext2D.globalCompositeOperation
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/HTMLIFrameElement/srcdoc
Title: HTMLIFrameElement.srcdoc
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/browserelement (url: /en-US/docs/Web/API/BrowserElement) does not exist

URL: /en-US/docs/Web/API/HTMLIFrameElement/src
Title: HTMLIFrameElement.src
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/browserelement (url: /en-US/docs/Web/API/BrowserElement) does not exist
    • /en-US/docs/Web/HTML/Element/src does not exist
    • /en-US/docs/Web/API/HTMLAnchorElement/src does not exist
    • /en-US/docs/Web/API/HTMLAreaElement/src does not exist
    • /en-US/docs/Web/API/HTMLAreaElement/src does not exist

URL: /en-US/docs/Web/API/HTMLIFrameElement/referrerPolicy
Title: HTMLIFrameElement.referrerPolicy
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/browserelement (url: /en-US/docs/Web/API/BrowserElement) does not exist

URL: /en-US/docs/Web/API/MediaStream_Recording_API/Using_the_MediaStream_Recording_API
Title: Using the MediaStream Recording API
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getRGBColorValue
Title: CSSPrimitiveValue.getRGBColorValue()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RGBColor does not exist
    • /en-US/docs/Web/API/RGBColor does not exist

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getRectValue
Title: CSSPrimitiveValue.getRectValue()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Rect does not exist
    • /en-US/docs/Web/API/Rect does not exist

URL: /en-US/docs/Web/API/MediaRecorder/stream
Title: MediaRecorder.stream
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/SVGGraphicsElement/copy_event
Title: SVGGraphicsElement: copy event
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/svgtests (url: /en-US/docs/Web/API/SVGTests) does not exist
    • /en-US/docs/Web/API/SVGGraphicsElement/oncopy does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.SVGGraphicsElement.copy_event

URL: /en-US/docs/Web/API/WebGLRenderingContext/getUniformLocation
Title: WebGLRenderingContext.getUniformLocation()
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/WebGLRenderingContext/vertexAttribPointer
Title: WebGLRenderingContext.vertexAttribPointer()
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/GLuint redirects to /en-US/docs/Web/API/WebGL_API/Types
    • /en-US/docs/Web/API/GLint redirects to /en-US/docs/Web/API/WebGL_API/Types
    • /en-US/docs/Web/API/GLenum redirects to /en-US/docs/Web/API/WebGL_API/Types
    • /en-US/docs/Web/API/GLboolean redirects to /en-US/docs/Web/API/WebGL_API/Types
    • /en-US/docs/Web/API/GLsizei redirects to /en-US/docs/Web/API/WebGL_API/Types
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/WebGLRenderingContext/enableVertexAttribArray
Title: WebGLRenderingContext.enableVertexAttribArray()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/GLuint redirects to /en-US/docs/Web/API/WebGL_API/Types
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/IDBDatabase
Title: IDBDatabase
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/IDBDatabase/createMutableFile does not exist

URL: /en-US/docs/Web/API/IDBRequest/source
Title: IDBRequest.source
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/IndexedDB/open does not exist

URL: /en-US/docs/Web/API/RTCIceCandidateStats/networkType
Title: RTCIceCandidateStats.networkType
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCStunServerConnectionStats does not exist
    • /en-US/docs/Web/API/RTCStunServerConnectionStats/networkType does not exist

External URLs

URL: /en-US/docs/Web/API/Element/setAttributeNode
Title: Element.setAttributeNode()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AnalyserNode/getFloatFrequencyData
Title: AnalyserNode.getFloatFrequencyData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGImageElement/decoding
Title: SVGImageElement.decoding
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ExtendableEvent/waitUntil
Title: ExtendableEvent.waitUntil()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NodeList/keys
Title: NodeList.keys()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NodeList/forEach
Title: NodeList.prototype.forEach()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NodeList/entries
Title: NodeList.entries()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NodeList/values
Title: NodeList.values()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Worklet/addModule
Title: Worklet.addModule()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/scale
Title: CanvasRenderingContext2D.scale()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/fillStyle
Title: CanvasRenderingContext2D.fillStyle
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/scrollPathIntoView
Title: CanvasRenderingContext2D.scrollPathIntoView()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/strokeRect
Title: CanvasRenderingContext2D.strokeRect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/resetTransform
Title: CanvasRenderingContext2D.resetTransform()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/setTransform
Title: CanvasRenderingContext2D.setTransform()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingQuality
Title: CanvasRenderingContext2D.imageSmoothingQuality
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/isPointInStroke
Title: CanvasRenderingContext2D.isPointInStroke()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/createImageData
Title: CanvasRenderingContext2D.createImageData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/globalAlpha
Title: CanvasRenderingContext2D.globalAlpha
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/lineCap
Title: CanvasRenderingContext2D.lineCap
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/lineJoin
Title: CanvasRenderingContext2D.lineJoin
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/transform
Title: CanvasRenderingContext2D.transform()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/shadowOffsetX
Title: CanvasRenderingContext2D.shadowOffsetX
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/moveTo
Title: CanvasRenderingContext2D.moveTo()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/getImageData
Title: CanvasRenderingContext2D.getImageData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/stroke
Title: CanvasRenderingContext2D.stroke()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/shadowBlur
Title: CanvasRenderingContext2D.shadowBlur
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/strokeStyle
Title: CanvasRenderingContext2D.strokeStyle
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/clip
Title: CanvasRenderingContext2D.clip()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/fillRect
Title: CanvasRenderingContext2D.fillRect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/getLineDash
Title: CanvasRenderingContext2D.getLineDash()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/textAlign
Title: CanvasRenderingContext2D.textAlign
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/fillText
Title: CanvasRenderingContext2D.fillText()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/createLinearGradient
Title: CanvasRenderingContext2D.createLinearGradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/save
Title: CanvasRenderingContext2D.save()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash
Title: CanvasRenderingContext2D.setLineDash()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/direction
Title: CanvasRenderingContext2D.direction
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/rect
Title: CanvasRenderingContext2D.rect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/fill
Title: CanvasRenderingContext2D.fill()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/rotate
Title: CanvasRenderingContext2D.rotate()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/beginPath
Title: CanvasRenderingContext2D.beginPath()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/lineTo
Title: CanvasRenderingContext2D.lineTo()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation
Title: CanvasRenderingContext2D.globalCompositeOperation
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/strokeText
Title: CanvasRenderingContext2D.strokeText()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/lineDashOffset
Title: CanvasRenderingContext2D.lineDashOffset
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/restore
Title: CanvasRenderingContext2D.restore()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/translate
Title: CanvasRenderingContext2D.translate()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/bezierCurveTo
Title: CanvasRenderingContext2D.bezierCurveTo()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/arcTo
Title: CanvasRenderingContext2D.arcTo()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/shadowOffsetY
Title: CanvasRenderingContext2D.shadowOffsetY
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingEnabled
Title: CanvasRenderingContext2D.imageSmoothingEnabled
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/measureText
Title: CanvasRenderingContext2D.measureText()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/shadowColor
Title: CanvasRenderingContext2D.shadowColor
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/filter
Title: CanvasRenderingContext2D.filter
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/clearRect
Title: CanvasRenderingContext2D.clearRect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/isPointInPath
Title: CanvasRenderingContext2D.isPointInPath()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/createRadialGradient
Title: CanvasRenderingContext2D.createRadialGradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/ellipse
Title: CanvasRenderingContext2D.ellipse()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/quadraticCurveTo
Title: CanvasRenderingContext2D.quadraticCurveTo()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/lineWidth
Title: CanvasRenderingContext2D.lineWidth
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/arc
Title: CanvasRenderingContext2D.arc()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/closePath
Title: CanvasRenderingContext2D.closePath()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasRenderingContext2D/createPattern
Title: CanvasRenderingContext2D.createPattern()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MessageChannel/port1
Title: MessageChannel.port1
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasGradient/addColorStop
Title: CanvasGradient.addColorStop()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLScriptElement/referrerPolicy
Title: HTMLScriptElement.referrerPolicy
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URLSearchParams/keys
Title: URLSearchParams.keys()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URLSearchParams/forEach
Title: URLSearchParams.forEach()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URLSearchParams/sort
Title: URLSearchParams.sort()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URLSearchParams/entries
Title: URLSearchParams.entries()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URLSearchParams/values
Title: URLSearchParams.values()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLIFrameElement/srcdoc
Title: HTMLIFrameElement.srcdoc
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLIFrameElement/src
Title: HTMLIFrameElement.src
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLIFrameElement/referrerPolicy
Title: HTMLIFrameElement.referrerPolicy
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WindowOrWorkerGlobalScope/indexedDB
Title: WindowOrWorkerGlobalScope.indexedDB
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStream_Recording_API/Using_the_MediaStream_Recording_API
Title: Using the MediaStream Recording API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Selection/deleteFromDocument
Title: Selection.deleteFromDocument()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getRGBColorValue
Title: CSSPrimitiveValue.getRGBColorValue()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getRectValue
Title: CSSPrimitiveValue.getRectValue()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPrimitiveValue/primitiveType
Title: CSSPrimitiveValue.primitiveType
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getFloatValue
Title: CSSPrimitiveValue.getFloatValue()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPrimitiveValue/getStringValue
Title: CSSPrimitiveValue.getStringValue()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FormData/keys
Title: FormData.keys()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FormData/entries
Title: FormData.entries()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FormData/values
Title: FormData.values()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/elementsFromPoint
Title: Document.elementsFromPoint()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Navigator/requestMediaKeySystemAccess
Title: Navigator.requestMediaKeySystemAccess()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBFactory
Title: IDBFactory
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBFactory/cmp
Title: IDBFactory.cmp()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/console/count
Title: console.count()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/stream
Title: MediaRecorder.stream
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioContext/createMediaStreamSource
Title: AudioContext.createMediaStreamSource()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSValue/cssText
Title: CSSValue.cssText
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSValue/cssValueType
Title: CSSValue.cssValueType
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBuffer/getChannelData
Title: AudioBuffer.getChannelData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBuffer/duration
Title: AudioBuffer.duration
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBuffer/length
Title: AudioBuffer.length
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBuffer/sampleRate
Title: AudioBuffer.sampleRate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBuffer/numberOfChannels
Title: AudioBuffer.numberOfChannels
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MutationObserver/takeRecords
Title: MutationObserver.takeRecords()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLCanvasElement/mozGetAsFile
Title: HTMLCanvasElement.mozGetAsFile()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLCanvasElement/toDataURL
Title: HTMLCanvasElement.toDataURL()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/channelCountMode
Title: AudioNode.channelCountMode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/numberOfInputs
Title: AudioNode.numberOfInputs
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/numberOfOutputs
Title: AudioNode.numberOfOutputs
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/connect
Title: AudioNode.connect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/channelCount
Title: AudioNode.channelCount
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioNode/context
Title: AudioNode.context
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/charging
Title: BatteryManager.charging
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/chargingTime
Title: BatteryManager.chargingTime
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/onchargingchange
Title: BatteryManager.onchargingchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/level
Title: BatteryManager.level
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/onchargingtimechange
Title: BatteryManager.onchargingtimechange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/dischargingTime
Title: BatteryManager.dischargingTime
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/ondischargingtimechange
Title: BatteryManager.ondischargingtimechange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BatteryManager/onlevelchange
Title: BatteryManager.onlevelchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGCircleElement/cx
Title: SVGCircleElement.cx
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGCircleElement/r
Title: SVGCircleElement.r
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGCircleElement/cy
Title: SVGCircleElement.cy
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Path2D/Path2D
Title: Path2D()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Path2D/addPath
Title: Path2D.addPath()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBEnvironment
Title: IDBEnvironment
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBufferSourceNode/loop
Title: AudioBufferSourceNode.loop
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBufferSourceNode/playbackRate
Title: AudioBufferSourceNode.playbackRate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioBufferSourceNode/detune
Title: AudioBufferSourceNode.detune
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTableElement/deleteTFoot
Title: HTMLTableElement.deleteTFoot()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTableElement/deleteCaption
Title: HTMLTableElement.deleteCaption()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTableElement/createCaption
Title: HTMLTableElement.createCaption()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTableElement/deleteTHead
Title: HTMLTableElement.deleteTHead()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTableElement/deleteRow
Title: HTMLTableElement.deleteRow()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGGraphicsElement/copy_event
Title: SVGGraphicsElement: copy event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebGLRenderingContext/getUniformLocation
Title: WebGLRenderingContext.getUniformLocation()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebGLRenderingContext/vertexAttribPointer
Title: WebGLRenderingContext.vertexAttribPointer()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebGLRenderingContext/enableVertexAttribArray
Title: WebGLRenderingContext.enableVertexAttribArray()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Headers/keys
Title: Headers.keys()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Headers/entries
Title: Headers.entries()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Headers/values
Title: Headers.values()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Response/json
Title: Response.json()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLSelectElement/selectedIndex
Title: HTMLSelectElement.selectedIndex
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createBuffer
Title: BaseAudioContext.createBuffer()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createDelay
Title: BaseAudioContext.createDelay()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/destination
Title: BaseAudioContext.destination
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/listener
Title: BaseAudioContext.listener
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createChannelSplitter
Title: BaseAudioContext.createChannelSplitter()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createBufferSource
Title: BaseAudioContext.createBufferSource()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createDynamicsCompressor
Title: BaseAudioContext.createDynamicsCompressor()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/sampleRate
Title: BaseAudioContext.sampleRate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BaseAudioContext/currentTime
Title: BaseAudioContext.currentTime
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBIndex/get
Title: IDBIndex.get()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/setValueAtTime
Title: AudioParam.setValueAtTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/exponentialRampToValueAtTime
Title: AudioParam.exponentialRampToValueAtTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/value
Title: AudioParam.value
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/maxValue
Title: AudioParam.maxValue
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/minValue
Title: AudioParam.minValue
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/setTargetAtTime
Title: AudioParam.setTargetAtTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/defaultValue
Title: AudioParam.defaultValue
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioParam/setValueCurveAtTime
Title: AudioParam.setValueCurveAtTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration_Block
Title: CSS Declaration Block
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase
Title: IDBDatabase
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/name
Title: IDBDatabase.name
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/objectStoreNames
Title: IDBDatabase.objectStoreNames
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/version
Title: IDBDatabase.version
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/onversionchange
Title: IDBDatabase.onversionchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/createObjectStore
Title: IDBDatabase.createObjectStore()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/onerror
Title: IDBDatabase.onerror
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/onabort
Title: IDBDatabase.onabort
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabase/close
Title: IDBDatabase.close()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CanvasPattern/setTransform
Title: CanvasPattern.setTransform()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/TextMetrics/width
Title: TextMetrics.width
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers/ontransitioncancel
Title: GlobalEventHandlers.ontransitioncancel
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers/ontransitionend
Title: GlobalEventHandlers.ontransitionend
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBOpenDBRequest
Title: IDBOpenDBRequest
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBOpenDBRequest/onupgradeneeded
Title: IDBOpenDBRequest.onupgradeneeded
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/User_Timing_API/Using_the_User_Timing_API
Title: Using the User Timing API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
Title: Drawing shapes with canvas
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_text
Title: Drawing text
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Transformations
Title: Transformations
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Using_images
Title: Using images
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Compositing
Title: Compositing and clipping
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Advanced_animations
Title: Advanced animations
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors
Title: Applying styles and colors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBRequest/result
Title: IDBRequest.result
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBRequest/onsuccess
Title: IDBRequest.onsuccess
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBRequest/source
Title: IDBRequest.source
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/OscillatorNode/frequency
Title: OscillatorNode.frequency
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/OscillatorNode/type
Title: OscillatorNode.type
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/OscillatorNode/detune
Title: OscillatorNode.detune
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/OscillatorNode/setPeriodicWave
Title: OscillatorNode.setPeriodicWave()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLImageElement/decoding
Title: HTMLImageElement.decoding
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLImageElement/referrerPolicy
Title: HTMLImageElement.referrerPolicy
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioScheduledSourceNode/onended
Title: AudioScheduledSourceNode.onended
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats/networkType
Title: RTCIceCandidateStats.networkType
on GitHub

No new external URLs

(this comment was updated 2021-08-26 19:45:18.579167)

@wbamberg wbamberg changed the title Remove 'highlight:' class Remove 'highlight:[]' and 'highlight[]' classes Aug 26, 2021
@wbamberg wbamberg marked this pull request as ready for review August 26, 2021 19:17
@wbamberg wbamberg requested a review from a team as a code owner August 26, 2021 19:17
@wbamberg wbamberg requested review from Elchi3 and removed request for a team August 26, 2021 19:17
@wbamberg wbamberg marked this pull request as draft August 26, 2021 19:42
@wbamberg wbamberg marked this pull request as ready for review August 26, 2021 19:45
hamishwillee
hamishwillee reviewed Aug 26, 2021
View reviewed changes
files/en-us/web/api/navigator/requestmediakeysystemaccess/index.html
@@ -98,7 +98,7 @@ <h3 id="Firefox_compatibility_notes">Firefox compatibility notes</h3>

<p>For example:</p>

<pre class="example-bad brush: js highlight[5,8]">let clearKeyOptions = [
<pre class="example-bad brush: js">let clearKeyOptions = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does there need to be a separator? Not saying anything wrong with this, but it looks a bit odd to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between brush: and js? Technically yes although again I think we accept the no-space version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbamberg OK. Since the render works and you're happy to clean this up in source if the converted doesn't, I'll merged.

@hamishwillee hamishwillee merged commit c4f8e6b into mdn:main Aug 26, 2021
@mdn mdn deleted a comment Aug 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
@wbamberg wbamberg deleted the remove-highlight-class branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @hamishwillee