Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consecutive <dd> elements in Web/API #8475

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

wbamberg
Copy link
Collaborator

This is part of #8474.

This PR fixes <dl> elements which don't convert to Markdown because they contain consecutive <dd> elements. This is allowed in <dl> but not in the version of <dl> we support (https://developer.mozilla.org/en-US/docs/MDN/Contribute/Markdown_in_MDN#definition_lists). In practice, when this happens in our source, it is always (?) an error.

Usually this is a matter of converting <dd>s to <p> elements, but in a couple of places it got a bit more extensive:

@wbamberg wbamberg requested a review from a team as a code owner August 30, 2021 23:47
@wbamberg wbamberg requested review from jpmedley and removed request for a team August 30, 2021 23:47
@github-actions

This comment has been minimized.

@sideshowbarker sideshowbarker merged commit 830d51e into mdn:main Aug 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
@wbamberg wbamberg deleted the fix-consective-dd-api branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants