Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various dl api #8484

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Fix various dl api #8484

merged 2 commits into from
Aug 31, 2021

Conversation

wbamberg
Copy link
Collaborator

This is part of #8474.

This PR fixes a few assorted <dl> conversion problems. Usually this is when a list immediately starts a <dd> without any introductory text, which is technically allowed in our <dl>, but is not supported by the converter, and is almost always improved by some introductory text.

@wbamberg wbamberg requested a review from a team as a code owner August 31, 2021 05:19
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team August 31, 2021 05:19
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTML_DOM_API
Title: The HTML DOM API
on GitHub
Flaw count: 21

  • macros:
    • /en-US/docs/Web/API/HTMLDirectoryElement does not exist
    • /en-US/docs/Web/API/HTMLFrameElement does not exist
    • /en-US/docs/Web/API/HTMLIsIndexElement does not exist
    • /en-US/docs/Web/API/External does not exist
    • /en-US/docs/Web/API/ApplicationCache does not exist
    • and 5 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/DataTransfer/mozSetDataAt
Title: DataTransfer.mozSetDataAt()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsISupports does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIVariant does not exist

URL: /en-US/docs/Web/API/FileSystemEntrySync
Title: FileSystemEntrySync
on GitHub
Flaw count: 3

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • bad_bcd_queries:
    • No BCD data for query: api.FileSystemEntrySync

URL: /en-US/docs/Web/API/CaretPosition
Title: CaretPosition
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/CaretPosition/offsetNode does not exist
    • /en-US/docs/Web/API/CaretPosition/offset does not exist
    • /en-US/docs/Web/API/CaretPosition/getClientRect does not exist

URL: /en-US/docs/Web/API/MediaRecorder/MediaRecorder
Title: MediaRecorder()
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Web/API/FileError
    • Can't resolve /en-US/docs/Web/API/FileError
  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystem

URL: /en-US/docs/Web/API/MessageEvent/MessageEvent
Title: MessageEvent()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/WindowProxy does not exist

URL: /en-US/docs/Web/API/SVGMarkerElement/preserveAspectRatio
Title: SVGMarkerElement.preserveAspectRatio
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/svgfittoviewbox (url: /en-US/docs/Web/API/SVGFitToViewBox) does not exist

URL: /en-US/docs/Web/API/RTCConfiguration
Title: RTCConfiguration
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/RTCConfiguration/iceCandidatePoolSize does not exist
    • /en-US/docs/Web/API/RTCConfiguration/peerIdentity does not exist
    • /en-US/docs/Web/API/RTCConfiguration/rtcpMuxPolicy does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/AnalyserNode/AnalyserNode
Title: AnalyserNode()
on GitHub

URL: /en-US/docs/Web/API/HTML_DOM_API
Title: The HTML DOM API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DataTransfer/mozSetDataAt
Title: DataTransfer.mozSetDataAt()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DataTransfer/setDragImage
Title: DataTransfer.setDragImage()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DataTransfer/mozClearDataAt
Title: DataTransfer.mozClearDataAt()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DataTransfer/setData
Title: DataTransfer.setData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FileSystemEntrySync
Title: FileSystemEntrySync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Microdata_DOM_API
Title: Microdata DOM API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Request/mode
Title: Request.mode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CaretPosition
Title: CaretPosition
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSGroupingRule
Title: CSSGroupingRule
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaQueryListEvent/MediaQueryListEvent
Title: MediaQueryListEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AudioWorkletGlobalScope/registerProcessor
Title: AudioWorkletGlobalScope.registerProcessor
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/MediaRecorder
Title: MediaRecorder()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MessageEvent/MessageEvent
Title: MessageEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FileEntrySync
Title: FileEntrySync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGMarkerElement/preserveAspectRatio
Title: SVGMarkerElement.preserveAspectRatio
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCConfiguration
Title: RTCConfiguration
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FileSystemDirectoryHandle/getFileHandle
Title: FileSystemDirectoryHandle.getFileHandle()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Notification
Title: Notification
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NDEFReader/write
Title: NDEFReader.write()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NDEFReader/scan
Title: NDEFReader.scan()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Serial/requestPort
Title: Serial.requestPort()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ElementInternals/setValidity
Title: ElementInternals.setValidity()
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit 80db592 into mdn:main Aug 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
@wbamberg wbamberg deleted the fix-various-dl-api branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @teoli2003