Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Markdown] [Web/API] Remove name attribute api #8502

Merged
merged 2 commits into from
Sep 1, 2021
Merged

[Markdown] [Web/API] Remove name attribute api #8502

merged 2 commits into from
Sep 1, 2021

Conversation

wbamberg
Copy link
Collaborator

Part of #7898.

Removes <a name=... from the Web/API docs.

The only place I could find where these are being used for links is https://github.com/mdn/content/compare/main...wbamberg:remove-name-attribute-api?expand=1#diff-fccd055084e20ada96622f32dbb76aa4f9a528b3bb9205163285be0d83f0536d , which I fixed.

@wbamberg wbamberg requested a review from a team as a code owner August 31, 2021 21:25
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team August 31, 2021 21:25
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/IDBIndexSync
Title: IDBIndexSync
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /IDBDatabaseException

URL: /en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB
Title: Using IndexedDB
on GitHub
Flaw count: 3

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Web/API/FileError
    • Can't resolve /en-US/docs/Web/API/FileError
  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystem

URL: /en-US/docs/Web/API/IDBTransactionSync
Title: IDBTransactionSync
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /IDBObjectStoreSync

URL: /en-US/docs/Web/API/FileException
Title: FileException
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/IDBObjectStoreSync
Title: IDBObjectStoreSync
on GitHub
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Web/API/LocalFileSystemSync
Title: LocalFileSystemSync
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystemSync

URL: /en-US/docs/Web/API/XPathException
Title: XPathException
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.XPathException

URL: /en-US/docs/Web/API/IDBCursorSync
Title: IDBCursorSync
on GitHub
Flaw count: 2

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page

External URLs

URL: /en-US/docs/Web/API/IDBEnvironmentSync
Title: IDBEnvironmentSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/File_and_Directory_Entries_API/Introduction
Title: Introduction to the File and Directory Entries API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBIndexSync
Title: IDBIndexSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB
Title: Using IndexedDB
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IndexedDB_API/Basic_Terminology
Title: IndexedDB key characteristics and basic terminology
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabaseSync
Title: IDBDatabaseSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBDatabaseException
Title: IDBDatabaseException
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBTransactionSync
Title: IDBTransactionSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FileSystemSync
Title: FileSystemSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FileException
Title: FileException
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBObjectStoreSync
Title: IDBObjectStoreSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystemSync
Title: LocalFileSystemSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XPathException
Title: XPathException
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBCursorSync
Title: IDBCursorSync
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit d808d1e into mdn:main Sep 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
@wbamberg wbamberg deleted the remove-name-attribute-api branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @sideshowbarker