Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown] [Web/API] Fix heading IDs used in live samples #8543

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Sep 1, 2021

Fixes #8509 .

This PR basically adjusts EmbedLiveSample arguments so they match the generated ID for the heading, so the examples will still work in Markdown.

I've checked that the pages listed in that issue all work in a local MDN which has had this change applied, then been converted to Markdown.

@wbamberg wbamberg requested a review from a team as a code owner September 1, 2021 21:03
@wbamberg wbamberg requested review from jpmedley and removed request for a team September 1, 2021 21:04
@wbamberg wbamberg changed the title Fix heading IDs used in live samples [Markdown] [Web/API] Fix heading IDs used in live samples Sep 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Preview URLs

Flaws

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DataTransferItemList
Title: DataTransferItemList
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/DataTransferItemList/DataTransferItem redirects to /en-US/docs/Web/API/DataTransferItemList

URL: /en-US/docs/Web/API/setTimeout
Title: setTimeout()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/WindowOrworkerGlobalScope/setTimeout redirects to /en-US/docs/Web/API/setTimeout
    • /en-US/docs/Web/API/WindowOrworkerGlobalScope/setTimeout redirects to /en-US/docs/Web/API/setTimeout
  • bad_bcd_queries:
    • No BCD data for query: api.setTimeout

External URLs

URL: /en-US/docs/Web/API/Element/querySelector
Title: Element.querySelector()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DataTransferItemList
Title: DataTransferItemList
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DataTransferItemList/length
Title: DataTransferItemList.length
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLElement/focus
Title: HTMLElement.focus()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Navigator/canShare
Title: Navigator.canShare()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/EventTarget/addEventListener
Title: EventTarget.addEventListener()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CSS_Object_Model/Using_dynamic_styling_information
Title: Using dynamic styling information
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/setTimeout
Title: setTimeout()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers/onselectionchange
Title: GlobalEventHandlers.onselectionchange
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors
Title: Applying styles and colors
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document_Object_Model/Introduction
Title: Introduction to the DOM
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document_Object_Model/Traversing_an_HTML_table_with_JavaScript_and_DOM_Interfaces
Title: Traversing an HTML table with JavaScript and DOM Interfaces
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit a01f7e8 into mdn:main Sep 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
@wbamberg wbamberg deleted the fix-live-sample-ids branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Markdown] [Web/API] Fix live samples which use heading IDs that are not derived from heading text
2 participants