-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Markdown] [Web/SVG] Convert Web/SVG to Markdown - DO NOT SQUASH MERGE #9188
Conversation
This comment has been minimized.
This comment has been minimized.
To coordinate reviews I've created https://docs.google.com/spreadsheets/d/1ddI7K0uy0ZDyefFSC2hnNxiaO_xm3lBX4gFEC0zPDZM/edit#gid=0 As before, the purpose of this is just to ensure different people review different pages. |
I took a tiny few and added some notes to the spreadsheet |
Thanks! For your comment on http://localhost:5000/en-US/docs/Web/SVG/attribute/display "Code inside table", is that a comment about the terrible contrast? Because that's a Yari issue, that I would love to have fixed, but not one I can do anything about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added three commits to fix oddities (not sure it was the conversion, but they were trivial to fix).
For me, it is good to merge. @wbamberg I let you make the call.
(There was a 2nd occurrence of "note inside table" that is far too dark, but that's yari, not the conversion. |
Thanks @Rumyra and @teoli2003 for the reviews! |
See #8969 for the "preparation" work.
This PR converts Web/SVG to Markdown.
Conversion report summary:
Full conversion report: https://gist.github.com/wbamberg/03b1ada19cd261927560c44a56ec4b6b
The only unconverted elements are
<sub>
and tables.<sub>
For
<sub>
: these elements only occur in four files:https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/d
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/diffuseConstant
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/specularConstant
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/feConvolveMatrix
For such a small number of pages it seemed better to keep them, as we have in other places (#7898 (comment)).
<table>
For
<table>
, most uses of<table>
are either.properties
tables, which are all staying as HTML, or specifications tables.The specifications tables are generally Markdown-compatible, but they are almost all wider than the 150-character max width that we have adopted for GFM tables (https://developer.mozilla.org/en-US/docs/MDN/Contribute/Markdown_in_MDN#gfm_table_maximum_width).
In fact the narrowest spec table was 137 chars wide, and only about 30 spec tables out of about 240 are less than 150 chars wide. So it seemed better to be consistent here and just suppress table conversion throughout.