Internalize execCommand() editor example #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a couple of things here to get it working, I committed them here: https://github.com/Josh-Cena/mdn-dom-examples/compare/execcommand-ex...bsmth:dom-examples:execcommand-ex-brian?expand=1 - the diff is a little messed up though because of line endings, I ran: |
chore: minor edits
|
Thanks! I keep messing up the line endings because I'm not in the habit yet and I'm soon going back to mac anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mdn/content#16120. This example is interesting but too long, and uses bootstrap, so it's better to be standalone.
cc @bsmth