Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl.Locale.prototype.minimize() interactive example #1388

Merged
merged 13 commits into from
Jul 10, 2019

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jul 6, 2019

Added an interactive example for Intl.Locale.prototype.minimize().

Example renders correctly and outputs correct values.

Part of an MDN documentation effort for Intl.Locale started by Daniel Ehrenberg.

Thanks!

@wbamberg
Copy link
Contributor

wbamberg commented Jul 8, 2019

Thanks for this @jahzielv !

As for #1386 (comment), we could use const here instead of let. Also as for #1386 (comment), we could have an example with another language, although it seems less important than with maximize() since its behavior is less interesting.

"intlLocalePrototypeMinimize": {
"exampleCode": "./live-examples/js-examples/intl/intl-locale-prototype-minimize.html",
"fileName": "intl-locale-prototype-minimize.html",
"title": "JavaScript Demo: Intl.Locale.prototype.minimize",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "JavaScript Demo: Intl.Locale.prototype.minimize()".

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jahzielv , looks great!

@wbamberg wbamberg merged commit b43ce45 into mdn:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants